Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run shepherd via cron #76

Closed
wants to merge 3 commits into from
Closed

Conversation

shizunge
Copy link

@shizunge shizunge commented Jul 6, 2022

No description provided.

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 21, 2022
Copy link
Collaborator

@djmaze djmaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very late response!

Running shepherd via cron is a good idea. I find this approach using crond a bit ugly but I guess it's the easist way to do this cross-platform..

shepherd Outdated Show resolved Hide resolved
shepherd Outdated Show resolved Hide resolved
@stale stale bot removed wontfix labels Sep 22, 2022
@rbauduin
Copy link
Contributor

Wondering if it is the right way to handle it inside shepherd.
Maybe it would be better to have an option to run only once and not loop every 5 minutes, and leave the scheduling to a specialised tool like https://github.com/crazy-max/swarm-cronjob ?

@rbauduin
Copy link
Contributor

in relation to my previous comment, I just discovered the option RUN_ONCE_AND_EXIT exists already. IIUC together with https://github.com/crazy-max/swarm-cronjob (which I'm using successfully for db backups) it does provide the functionality of this PR.

@djmaze
Copy link
Collaborator

djmaze commented Oct 2, 2022

@rbauduin You are absolutely right. I am using that approach all the time but somehow this thought did not come to my mind when looking at this PR.

I would go even further and say the usage of swarm-cronjob should be the recommended approach of using shepherd. I guess we should adjust the README accordingly.

@shizunge Very sorry for the delay and everything, but with the above said it does not make sense to merge this PR.

@djmaze djmaze closed this Oct 2, 2022
@shizunge

This comment was marked as spam.

@djmaze
Copy link
Collaborator

djmaze commented Dec 20, 2022

See #89.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants