Fix ecommerce-app-base bug in drag-n-drop refetch logic #7944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecommerce-app-base-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ethan-ozelius-contentful
changed the title
| @@ -5,53 +5,7 @@ import { ConfigAppSDK } from '@contentful/app-sdk'; | |||
|
|
|||
| import AppConfig from './AppConfig'; | |||
| import { definitions } from './parameters.spec'; | |||
|
|
|||
There was a problem hiding this comment.
Copied/pasted this code out of AppConfig into __mocks__ dir so that other test files can re-use this functionality.
| @@ -57,28 +57,31 @@ export const SortableComponent: FC<Props> = ({ | |||
| const [productPreviews, setProductPreviews] = useState<Product[]>([]); | |||
| const previousSkus = usePreviousSkus(skus); | |||
|
|
|||
| const getProductPreviews = useCallback( | |||
There was a problem hiding this comment.
removed shouldRefetch arg from this callback and reversed the dependency, so that consumers of this callback are responsible for determining shouldRefetch. See line 82.
This has the added benefit of removing the productPreviews from the useCallback dependencies, which was causing this callback to be re-defined every time productPreviews state updated.
ethan-ozelius-contentful
force-pushed
the
eozelius/ecommerce-app-base/v4/fix-drag-n-drop
branch
2 times, most recently
from
b1b7308
to
dbbea6f
Compare
t-col
approved these changes
Jun 5, 2024
…using infinite loop
ethan-ozelius-contentful
force-pushed
the
eozelius/ecommerce-app-base/v4/fix-drag-n-drop
branch
from
dbbea6f
to
c64a7d9
Compare
whitelisab
approved these changes
Jun 5, 2024
ethan-ozelius-contentful
deleted the
eozelius/ecommerce-app-base/v4/fix-drag-n-drop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a bug that was introduced in this PR that was causing an infinite loop rerender to occur.
Root cause
usePreviousSkus()hook is invoked to trackskusfrom previous mount,fetchProductPreviews()on mount, as expected.fetchProductPreviews()retrieves product previews via network requestfetchProductPreviews()updates theproductPreviewsstate, causing a rerender, as expected.usePreviousSkus()runs and retrieves the list of skus from previous mount, as well as updates the current ref to the most current list of skus (list of skus received via props).previousSkusas a dependency, the useEffect runs again. Setting off an infinite loop.Screen capture of working solution
Approach
Testing steps
Breaking Changes
Dependencies and/or References
Deployment