feat: add hosted app actions for sap [EXT-5612] #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitelisab
commented
Aug 16, 2024
There was a problem hiding this comment.
I added this test handler and .spec file for it to just have a test that is passing in this folder. We can remove this down the road.
whitelisab
commented
Aug 16, 2024
|
|
||
| return { | ||
| status: 'Success', | ||
| // @ts-ignore |
There was a problem hiding this comment.
You'll see this in a few places in these app actions. I just opted to ignore ts errors for now since these will need to be refactored to work anyway.
whitelisab
commented
Aug 16, 2024
There was a problem hiding this comment.
Changes in this file: I renamed the frontend app and removed all of the deploy scripts; those are now in the top level package.json
whitelisab
commented
Aug 16, 2024
There was a problem hiding this comment.
This is something we've used in other apps and it's useful for testing app actions
mgoudy91
reviewed
Aug 16, 2024
jjolton-contentful
approved these changes
Aug 16, 2024
mgoudy91
approved these changes
Aug 16, 2024
whitelisab
force-pushed
the
feat/add-haa-for-sap-air
branch
from
59cc866
to
dbc16a7
Compare
mgoudy91
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat: reorganize app to introduce haa * chore: add more template files to app actions and remove deploy scripts from frontend
mgoudy91
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat: reorganize app to introduce haa * chore: add more template files to app actions and remove deploy scripts from frontend
mgoudy91
pushed a commit
that referenced
this pull request
Aug 27, 2024
* feat: reorganize app to introduce haa * chore: add more template files to app actions and remove deploy scripts from frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We will use hosted app actions to make api calls with the AIR header for the SAP AIR app. This PR introduces a lot of the boilerplate around hosted app actions.
Approach
Updated the SAP app to follow the project structure and boilerplate used in the MS Teams and Vercel apps. See this PR as an example for Vercel: #6769
Specifically, here is a summary of the changes:
frontenddirectoryvite.configto support parent project build outDir locationapp-actionsdirectoryTesting steps
I confirmed that I could successfully build the frontend and actions and deployed to both staging apps. Confirmed that the app config page and field locations are rendering for both staging apps. I am not able to see products in the Dialog, but that's also a problem I am seeing on our feature branch.
Breaking Changes
Dependencies and/or References
Deployment