Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rich text example: enabledMarks & enabledNodeTypes #1290

Merged
merged 2 commits into from
Feb 20, 2024
Merged

rich text example: enabledMarks & enabledNodeTypes #1290

merged 2 commits into from
Feb 20, 2024

Conversation

neptunus
Copy link
Contributor

Added missing marks and nodeTypes to example 22 to improve it as a reference

Summary

Example 22 (create-rich-text-field-with-validation) expanded to include marks such as "bold", and missing node-types such as "table".

Description

I created a new rich text field with everything enabled, then used the contentful cli tool to generate a migration based on that; the output of which I used to fill in the blank spots of the example code.

Motivation and Context

To improve the example as a reference. I recently had a teammate struggle to find examples of adding table support to rich text using this library—looking at this example I found that it was missing just a few items to serve as a complete reference.

@neptunus neptunus requested a review from a team as a code owner February 18, 2024 16:35
Added missing marks and nodeTypes to example 22 to improve it as a reference
Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR!

@mgoudy91 mgoudy91 merged commit afe1345 into contentful:master Feb 20, 2024
2 checks passed
@contentful-automation
Copy link

🎉 This PR is included in version 4.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@neptunus neptunus deleted the improve-example-22 branch March 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants