Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nodeType to SizeValidationError [DANTE-1114] #1807

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

alicandko
Copy link
Contributor

@alicandko alicandko commented Jan 19, 2024

Purpose of PR

The error messages for rich text nodes are not descriptive enough. For better error messages we need to know the nodeType. SizeValidationError in this package is used here.

DANTE-1114

PR Checklist

  • Tests are added/updated/not required
  • Tests are passing
  • Typescript typings are added/updated/not required

@alicandko alicandko requested a review from a team as a code owner January 19, 2024 13:07
@alicandko alicandko changed the title feat: add nodeType to SizeValidationError feat: add nodeType to SizeValidationError [DANTE-1114] Jan 19, 2024
@alicandko alicandko enabled auto-merge (squash) January 19, 2024 14:27
@alicandko alicandko merged commit 735e915 into master Jan 19, 2024
4 checks passed
@alicandko alicandko deleted the DANTE-1114 branch January 19, 2024 14:28
contentful-automation bot added a commit that referenced this pull request Jan 19, 2024
# [4.24.0](v4.23.1...v4.24.0) (2024-01-19)

### Features

* add nodeType to SizeValidationError [DANTE-1114] ([#1807](#1807)) ([735e915](735e915))
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 4.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants