Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [EXT-2242] Add typings and expose metadata methods #865

Merged
merged 3 commits into from
Jul 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions lib/entry.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Channel } from './channel'
import { MemoizedSignal } from './signal'
import { EntryAPI, EntryFieldInfo, TaskAPI } from './types'
import { EntryAPI, EntryFieldInfo, Metadata, TaskAPI } from './types'

const taskMethods: Array<keyof TaskAPI> = [
'getTask',
Expand All @@ -18,13 +18,19 @@ export default function createEntry(
): EntryAPI {
let sys = entryData.sys
const sysChanged = new MemoizedSignal(sys)
const entryMetadata = entryData.metadata
let metadata = entryData.metadata
const metadataChanged = new MemoizedSignal(metadata)

channel.addHandler('sysChanged', (_sys: any) => {
sys = _sys
sysChanged.dispatch(sys)
})

channel.addHandler('metadataChanged', (_metadata: Metadata) => {
metadata = _metadata
metadataChanged.dispatch(metadata)
})

const taskApi = {} as TaskAPI

taskMethods.forEach((methodName) => {
Expand All @@ -44,7 +50,13 @@ export default function createEntry(
acc[info.id] = createEntryField(info)
return acc
}, {}),
...(entryMetadata ? { metadata: entryMetadata } : {}),
...(metadata ? { metadata } : {}),
getMetadata() {
return metadata
},
onMetadataChanged(handler: VoidFunction) {
return metadataChanged.attach(handler)
},
...taskApi,
}
}
10 changes: 7 additions & 3 deletions lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ export interface EntrySys {
contentType: Link
}

export interface Metadata {
tags?: Link[]
}

/* Field API */
export interface FieldAPI {
/** The ID of a field is defined in an entry's content type. */
Expand Down Expand Up @@ -227,9 +231,9 @@ export interface EntryAPI extends TaskAPI {
* Optional metadata on an entry
* @deprecated
*/
metadata?: {
tags?: Link[]
}
metadata?: Metadata
getMetadata: () => Metadata | undefined
onMetadataChanged: (callback: (metadata?: Metadata) => void) => VoidFunction
}

/* Scheduled Actions */
Expand Down