Merge pull request #42 from contentstack/error_handling

Unhandled Promise rejection issue resolve
contentstack · Jan 22, 2021 · 4ef7d07 · 4ef7d07
2 parents 41f6a3d + 280971b
commit 4ef7d07
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
+
+### Version: 3.12.1
+#### Date: Jan-22-2021
+
+##### Bug fix:
+ - Fixed Unhandled promise rejection on HTML response body.
 ### Version: 3.12.0
-#### Date: Desc-05-2020
+#### Date: Dec-05-2020
 
 ##### New Features:
  - [Entry] - Publish fallback method added

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "contentstack",
-  "version": "3.12.0",
+  "version": "3.12.1",
   "description": "Contentstack Javascript SDK",
   "homepage": "https://www.contentstack.com/",
   "author": {

diff --git a/src/core/lib/request.js b/src/core/lib/request.js
@@ -57,7 +57,9 @@ function wait(retryDelay) {
         setTimeout(resolve, retryDelay)
     });
 }
-
+async function safeParseJSON(response) {
+    const body = await response.text();
+}
 function fetchRetry(url, headers, retryDelay = 300, retryLimit = 5, fetchOptions, resolve, reject) {
     var option = Object.assign({ 
         method: 'GET',
@@ -87,7 +89,7 @@ function fetchRetry(url, headers, retryDelay = 300, retryLimit = 5, fetchOptions
         }
     }
     fetch(url, option)
-        .then(function(response) {       
+        .then(function(response) {    
             let data = response.json();      
             if (response.ok && response.status === 200) {
                 resolve(data);
@@ -98,6 +100,8 @@ function fetchRetry(url, headers, retryDelay = 300, retryLimit = 5, fetchOptions
                     } else {
                         reject(json)
                     }   
+                }).catch(() => {
+                    reject({status: response.status, statusText: response.statusText})
                 });
             }
         }).catch((error) => {