Feat/cs 43299 gcp #107
Merged
Feat/cs 43299 gcp #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhinav-from-contentstack
commented
Jan 4, 2024
•
abhinav-from-contentstack
commented
- added region gcp_na
- added taxonomy support
- added relevant e2e tests and unit tests
- updated existing test cases
- resolved dependency conflicts
- version bumped to 3.18.0
| @@ -89,7 +90,7 @@ test('Invalid URL: multiple parameter testing', function(assert) { | |||
| auto: 'webp', | |||
| format: 'jpg' | |||
| } | |||
| const URL = Asset.get('url') + '?'; | |||
| const URL = Asset['url'] + '?'; | |||
There was a problem hiding this comment.
@nadeem-cs @abhinav-from-contentstack can you please confirm .get function were not working properly before ?
There was a problem hiding this comment.
@ishaileshmishra .get function is not required now. Value can be directly accessed using Object key.
cc @abhinav-from-contentstack
ishaileshmishra
suggested changes
Jan 4, 2024
There was a problem hiding this comment.
Please review the provided comments @abhinav-from-contentstack @abhinav-from-contentstack
and let me know if any clarifications are required.
|
Kindly close the redundant pull requests initiated by either the bot or yourself. @abhinav-from-contentstack |
|
Hi @ishaileshmishra, I've done the requested changes. Please check and approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.