Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Upgrade to Node 20 #149

Closed
leondz opened this issue Mar 24, 2024 · 7 comments
Closed

[Feature] Upgrade to Node 20 #149

leondz opened this issue Mar 24, 2024 · 7 comments
Labels
feature

Comments

@leondz
Copy link

leondz commented Mar 24, 2024

Is your feature request related to a problem? Please describe.
contributor-assistant uses a deprecated version of Node (see https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/)

Describe the solution you'd like
Would like contributor-assistant to use Node 20
@leondz leondz added the feature label Mar 24, 2024
@ibakshay
Copy link
Member

Hi @leondz,
Thanks a lot. I will upgrade and do a new release within a week. Let us keep this issue till then.

@azzamsa azzamsa mentioned this issue Jun 27, 2024
Closed
@kingthorin
Copy link
Contributor

It's been about 15 weeks. Any news?

@ibakshay
Copy link
Member

It's been about 15 weeks. Any news?

Node has been upgarded with the latest release. I apologise for a LONG delay.

Please update the version of contributor-assistant/github-action to v2.5.0 in your repository.

@kingthorin
Copy link
Contributor

Great, thank you!! 😊

@kingthorin
Copy link
Contributor

kingthorin commented Aug 16, 2024 •
edited
Loading

@ibakshay Uh oh, looks like you updated CI but still left the action using 16:

github-action/action.yml

Line 42 in 288ded2

using: "node16"

@ibakshay
Copy link
Member

@ibakshay Uh oh, looks like you updated CI but still left the action using 16:

github-action/action.yml

Line 42 in 288ded2

using: "node16"

Great catch!
I did a quick patch and released a new version now :)
https://github.com/contributor-assistant/github-action/releases/tag/v2.5.1

@kingthorin
Copy link
Contributor

Thanks!

kingthorin added a commit to kingthorin/zap-extensions that referenced this issue Aug 16, 2024
@kingthorin
Update CLA Assistant
0fef28a 
- 2.5.0 which uses node 20 vs node 16

Ref: contributor-assistant/github-action#149

Signed-off-by: kingthorin <[email protected]>
This was referenced Aug 16, 2024
Merged
Merged
kingthorin added a commit to kingthorin/zap-extensions that referenced this issue Aug 16, 2024
@kingthorin
Update CLA Assistant
e014267 
- 2.5.1 which uses node 20 vs node 16

Ref: contributor-assistant/github-action#149

Signed-off-by: kingthorin <[email protected]>
kingthorin added a commit to kingthorin/zaproxy that referenced this issue Aug 16, 2024
@kingthorin
Update CLA Assistant
cf7af2d 
- 2.5.1 which uses node 20 vs node

Ref: contributor-assistant/github-action#149

Signed-off-by: kingthorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@leondz @kingthorin @ibakshay