Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run E2E tests with actual Redis #52

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

jankonas
Copy link
Contributor

Suggestions how to add redis and keep remote nette-tester template are welcome :-)

@f3l1x
Copy link
Member

f3l1x commented Dec 23, 2023

Hi @jankonas, can you please create nette-tester-redis in contributte/.github repo? Similar to https://github.com/contributte/.github/blob/master/.github/workflows/nette-tester-mysql.yml, thanks.

@jankonas
Copy link
Contributor Author

Hi @jankonas, can you please create nette-tester-redis in contributte/.github repo? Similar to https://github.com/contributte/.github/blob/master/.github/workflows/nette-tester-mysql.yml, thanks.

Sure contributte/.github#6

@jankonas
Copy link
Contributor Author

I updated this PR with uses of workflow contributte/.github/.github/workflows/nette-tester-redis.yml@v2 which does not yet exitsts. After merging contributte/.github#6 we'll see what the correct path should be.

@f3l1x
Copy link
Member

f3l1x commented Feb 28, 2024

Done. Please use nette-tester-redis.yml@master

@jankonas
Copy link
Contributor Author

jankonas commented Mar 6, 2024

Done. Please use nette-tester-redis.yml@master

Done :-)

@f3l1x
Copy link
Member

f3l1x commented Apr 24, 2024

👍

@f3l1x
Copy link
Member

f3l1x commented Apr 24, 2024

Can you please rebase it? @jankonas

@f3l1x f3l1x merged commit 9075d70 into contributte:master May 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants