Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace globby with glob in the project for smaller footprint #2370

Closed
escapedcat opened this issue Dec 15, 2020 · 7 comments · Fixed by #3438
Closed

Replace globby with glob in the project for smaller footprint #2370

escapedcat opened this issue Dec 15, 2020 · 7 comments · Fixed by #3438
Labels
enhancement good first issue

Comments

@escapedcat
Copy link
Member

Replace globby with glob in all commitlint-packages.
@escapedcat escapedcat mentioned this issue Dec 15, 2020
Merged
7 tasks
@AdeAttwood AdeAttwood mentioned this issue Jul 24, 2021
Closed
1 task
@MadhaviMandalia
Copy link
Contributor

Hello @escapedcat
Can I contribute on this issue?

@escapedcat
Copy link
Member Author

Yeah, sure. Eventually just switching it should work ™️
Let me know if you run into issues.

@MadhaviMandalia
Copy link
Contributor

@escapedcat ok thanks.
I have reviewed this issue. So instead of globby @11.0.1 we need to replace glob @7.1.6 in the whole project.
Let me know is it correct?

@escapedcat
Copy link
Member Author

Looks like v7.2.0 is latest. You can use that directly.
Good luck :)

@MadhaviMandalia
Copy link
Contributor

MadhaviMandalia commented Jan 4, 2022 •
edited
Loading

Should I just remove globby v11.0.0, v11.0.1, v11.0.2, v11.0.4 to put only one glob?

image

@escapedcat
Copy link
Member Author

This is form the lock-file? No need to change that. Once you remove globby from all package.jsons and do a yarn the lock file should update itself. If other deps need globby that's still ok.

MadhaviMandalia added a commit to MadhaviMandalia/commitlint that referenced this issue Jan 4, 2022
@MadhaviMandalia
fix(package.json): replaced globby with glob conventional-changelog#2370
35ca695
@MadhaviMandalia
Copy link
Contributor

Yes, Ok thanks for the suggestions. I have raised a PR #2952 please check and let me know if there is any change 👍

Thanks & Regards.

sjarva added a commit to sjarva/commitlint that referenced this issue Dec 15, 2022
@sjarva
chore: change globby library to glob
377e343 
Closes conventional-changelog#2370
@sjarva sjarva mentioned this issue Dec 15, 2022
Merged
7 tasks
escapedcat pushed a commit that referenced this issue Dec 15, 2022
@sjarva
chore: change globby library to glob (#3438)
33e4f4e 
Closes #2370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: change globby library to glob sjarva/commitlint
2 participants
@escapedcat @MadhaviMandalia