Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Configurable delimiter for scope #701

Open
1 of 4 tasks
just-boris opened this issue Jun 21, 2019 · 3 comments
Open
1 of 4 tasks

Feature request: Configurable delimiter for scope #701

just-boris opened this issue Jun 21, 2019 · 3 comments

Comments

@just-boris
Copy link

Expected Behavior

I expect that commit message fix(module-a,module-b): Do something will pass scope-case rule.

Current Behavior

It fails, because it does not treat comma as a valid separator

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

Make these delimiters configurable: https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/rules/src/scope-case.js#L25

Context

Sometimes there are commits that span across multiple modules. Currently they do not pass the linter. Splitting into multiple is not possible if committed changes require simultaneous update of all affected parts.

@escapedcat
Copy link
Member

We do support comma by now:
https://commitlint.js.org/concepts/commit-conventions.html#multiple-scopes
But the delimiter can not be configured. Not sure if this is still needed though.

@wlc015f
Copy link

wlc015f commented Apr 9, 2024

We do support comma by now: https://commitlint.js.org/concepts/commit-conventions.html#multiple-scopes But the delimiter can not be configured. Not sure if this is still needed though.

our projects previous use scope like: feat(A/B): commit msg, B is a sub scope of A, but for now "/" is scopes delimiter to divide input scope string into several scopes, when we update @commitlint/[email protected] , it doesn't work well as before, i wonder if we can config scope delimiter may solve my problem

@escapedcat
Copy link
Member

when we update @commitlint/[email protected] , it doesn't work well as before

Maybe open a separate new issue for this first. Everything that worked should still work the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants