Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few questions about project #918

Closed
armano2 opened this issue Jan 29, 2020 · 2 comments · Fixed by #960
Closed

Few questions about project #918

armano2 opened this issue Jan 29, 2020 · 2 comments · Fixed by #960

Comments

@armano2
Copy link
Contributor

armano2 commented Jan 29, 2020

  1. What version of node commitlint is currently supporting?
    engines.node in most packages states 4, in root you can find 6 but some of dependencies require 8 and tests are executed on 8+. Should we align this?
  2. Why so many different fs packages? maybe we should pick one and stick to it
    What we should use? mayby we should just stick with fs and promisify?
  3. Currently tests are creating a lot of temporary directories, but they never clean them up
    tmp has mechanism to clean temporary files before program is closing, but due to isolation of jest it never gets triggered, than we have to call it manually
@marionebl
Copy link
Contributor

marionebl commented Jan 29, 2020

What version of node commitlint is currently supporting?

Officially it is 8 - we support LTS releases until they hit EOL. This is true for 8 since 2019-12-31, so we can roll over to support 10, 12 and eventually 14. Let's clean up older data.

Why so many different fs packages?

Historic drift. commitlint is under development since February 2016 :) Let's clean that up asap.

Currently tests are creating a lot of temporary directories

I'd hope we can get rid of this by mocking away most things via jest.
Also there is the general idea to use an injected file system facade in commitlint which may then be used to test on an in memory fs.

@byCedric
Copy link
Member

There is a roadmap for v9 in the makings, but we need to discuss it before publishing it. That might help provide a clear direction where we are working towards to 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants