Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(test): remove temp files after test run #960

Merged
merged 3 commits into from
Feb 6, 2020

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Feb 6, 2020

remove temp files after test run

Description

Currently tests are creating a lot of temporary directories, but they never clean them up
tmp has mechanism to clean temporary files before program is closing, but due to isolation of jest it never gets triggered.

raszi/node-tmp#229

closes #918

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

jest.config.js Outdated Show resolved Hide resolved
@marionebl marionebl merged commit 5281822 into conventional-changelog:master Feb 6, 2020
@armano2 armano2 deleted the tmp-fix branch February 6, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Few questions about project
2 participants