feat: allow multiple local plugins #1980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest merging #1976 before this one :) |
byCedric
approved these changes
Jun 28, 2020
byCedric
reviewed
Jun 28, 2020
| @@ -24,6 +24,12 @@ import {pickConfig} from './utils/pick-config'; | |||
| const w = <T>(_: unknown, b: ArrayLike<T> | null | undefined | false) => | |||
| Array.isArray(b) ? b : undefined; | |||
|
|
|||
| const generateLocalId = () => { | |||
| let id = 0; | |||
There was a problem hiding this comment.
Isn't this redefined every time you run the method?
There was a problem hiding this comment.
Yes but it is only run once. The function that is run multiple times is this one:
return () => `local-${id++}`;It is a closure :)
There was a problem hiding this comment.
I was considering to just declare id on row 95 and do the logic for generating an id in row 101. Do you think the code is clearer that way?
|
@juliuscc sorry, this got lost on the way. Might be better to just merge this in even though some questions are open. Would you mind rebasing it? Then we could merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for multiple local plugins to be loaded.
Description
The plugins are usually loaded by their name and added to an object, with their name as key. Local plugins do not have a name so they were previously saved as 'local' in the same object. If you loaded multiple local plugins the value was overwritten.
This PR saves all local plugins on a unique key. They are called
local-0,local-1, etc.Motivation and Context
First of all you can have multiple local plugins. This means that you can export and import them without having to merge them. This also means that you can include multiple shareable plugins that include local plugins, without them overwriting each other.
Usage examples
Self-explanatory.
How Has This Been Tested?
I have added a test for multiple plugins, and they are correctly loaded.
I have not tested how it works when you include multiple shared configurations with plugins or a mix of local plugins in your config and from a shared config. This is because currently, the master branch does not support plugins from shared configs in any way. When that is fixed we can add tests for this.
Types of changes
Checklist: