Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to specify conventional changelog preset #170

Conversation

lancecaraccioli
Copy link

@lancecaraccioli lancecaraccioli commented Apr 13, 2017

should close #169

@coveralls
Copy link

coveralls commented Apr 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d627191 on lancecaraccioli:issue-169 into 2429a68 on conventional-changelog:master.

@bcoe
Copy link
Member

bcoe commented May 5, 2017

@lancecaraccioli we're having a similar conversation on lerna:

lerna/lerna#786

My concern is that tools like conventional-recommended-bump currently assume the angular commit style -- rather than introducing configuration toggles into standard-version. I'd rather keep perfecting this spec:

https://conventionalcommits.org/

@Tapppi thoughts?

@lancecaraccioli
Copy link
Author

My specific use case is that our repository is BitBucket and our issue tracker is Jira. The only other option would be to fork conventional-changlog-angular and maintain, what feels to be, a dirty copy.

by allowing conventional-changlog-VENDOR to be owned by VENDOR as an external repository, with the addition of this PR then it's possible to wire up to VENDOR specific resources.

@lancecaraccioli lancecaraccioli changed the title feat: add ability to specify which conventional changelog preset shou… feat: add ability to specify conventional changelog preset May 5, 2017
@bcoe
Copy link
Member

bcoe commented May 14, 2017

@lancecaraccioli would love to support your use-case; so that I better understand -- does Jira have a specific commit format that it forces you to adhere to?

@lancecaraccioli
Copy link
Author

lancecaraccioli commented May 17, 2017

@bcoe We have specific URL paths for user urls, bug links, diff links, etc. I believe I made a minor change to a template. I'll paste it here when I start work on polishing the docs for the PR

@bcoe
Copy link
Member

bcoe commented May 17, 2017

@lancecaraccioli okay cool -- what I was coming to; was maybe we could support this use-case by passing in an appropriate template context, and making some tweaks to the template 👍 (rather than adding more configuration toggles).

we could even publish a Jira preset 👓 using this new feature we've been building out in yargs:

https://github.com/yargs/yargs#extends-keyword

@bcoe
Copy link
Member

bcoe commented Jun 5, 2017

@lancecaraccioli I think we just need to add a couple optional parameters for specifying the issue URL, and to extend this functionality slightly:

https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-changelog-angular/index.js#L30

what do you think?

@Jule-
Copy link

Jule- commented Oct 4, 2018

Definitely need this feature!
Indeed I was about to do exactly the same PR...

@bcoe
Copy link
Member

bcoe commented Nov 1, 2018

cleaning up some old pull requests, please feel free to reopen this conversation if you're still interested in implementing this.

@bcoe bcoe closed this Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Allow passing a an optional conventional-changelog "preset" option
6 participants