Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generated github token form pull_request comment #68

Closed
wants to merge 1 commit into from
Closed

Use generated github token form pull_request comment #68

wants to merge 1 commit into from

Conversation

bogaertg
Copy link
Contributor

@bogaertg bogaertg commented Nov 8, 2022

Hi,

There is two Github API call in this action:

  • one for trigger remote workflow with a specific PAT token
  • one for pull_request comments.

By design, Github token has access to pull_request comment
I thin it's better to use autogenerated github token for pull request comments. Moreover, we didn't need comments pull request on remote repository.

What do you think about it ?

Here is test repo for my fork

Regards
Gaetan

@bogaertg bogaertg changed the title Update action.yml Use generated github token form pull_request comment Nov 8, 2022
@bogaertg bogaertg marked this pull request as ready for review November 8, 2022 12:02
@rabih
Copy link
Contributor

rabih commented Nov 16, 2022

Pulled this in as part of #74.

Thank you for your contribution!!

@rabih rabih closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants