Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CELERY_BROKER_URL in favor of REDIS_URL #4861

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

foarsitter
Copy link
Collaborator

As discussed in #4811 this is how it looks like to remove CELERY_BROKER_URL.

Considering the amount of deletions, this looks like the right path.

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance - could you please merge/rebase the latest master to do some final chackes?

Comment on lines -58 to -59
# Optional: set broker URL if using Celery
$ export CELERY_BROKER_URL=redis://localhost:6379/0
Copy link
Member

@browniebroke browniebroke Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this tell people to set the REDIS_URL instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't longer required as it has a default I think

{{cookiecutter.project_slug}}/docs/conf.py Show resolved Hide resolved
@foarsitter
Copy link
Collaborator Author

Thanks for your valuable feedback @browniebroke!

@foarsitter foarsitter merged commit 9806ba7 into cookiecutter:master Oct 21, 2024
13 checks passed
@foarsitter foarsitter deleted the remove_celery_broker_url branch October 21, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants