Add workflow to run uv lock #5422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding a dependency through If we commit 'uv.lock', is a workflow like this then required? |
|
This workflow is mainly for dependabot PRs, which AFAIK doesn't support |
browniebroke
force-pushed
the
uv-lock-workflow
branch
from
c7671a6
to
785b024
Compare
Should do the job for dependabot updates
browniebroke
force-pushed
the
uv-lock-workflow
branch
from
785b024
to
15556a0
Compare
|
Clever! |
browniebroke
commented
Oct 7, 2024
Comment on lines
+21
to
+22
| with: | ||
| token: ${{ env.GH_PAT }} |
There was a problem hiding this comment.
This is needed to make sure that CI runs again on pushes, see: https://github.com/stefanzweifel/git-auto-commit-action#commits-made-by-this-action-do-not-trigger-new-workflow-runs
browniebroke
commented
Oct 7, 2024
Comment on lines
+24
to
+26
| - name: Checkout without token | ||
| uses: actions/checkout@v4 | ||
| if: ${{ env.GH_PAT == '' }} |
There was a problem hiding this comment.
Added this fallback in case the secret isn't accessible, which unfortunately the case sometimes...
foarsitter
approved these changes
Oct 7, 2024
|
Ok, let's try this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build on top of #5356 to add a uv lock workflow
Checklist:
Rationale
At time of writing, Dependabot doesn't yet support
uv.lockfile: dependabot/dependabot-core#10478 but it does support package deps inpyproject.toml, which means that we will get PRs to updates our template deps, but they will leave the lockfile out of sync.This workflow is a workaround for that, and will attempt to regenerate the lockfile each time the
pyproject.tomlfile is changed by a pull request.