-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistant sound volume when player state changes #357
Comments
Problems comes from onPlay As ReactPlayer state is not updated when changing volume manually it will always go back to its default value when seeking or pausing / playing. I don't know about other players but Youtube API doesn't seems to provide a Would you accept a PR implementing this solution @cookpete ? |
As of |
Thanks, that was fast ! |
The only downside to this is that |
- Fixes cookpete/react-player#357 - Fixes `onStart` not firing when changing URLs - Moves the forced `setVolume` to run on ready instead of every play event
- Fixes cookpete/react-player#357 - Fixes `onStart` not firing when changing URLs - Moves the forced `setVolume` to run on ready instead of every play event
- Fixes cookpete/react-player#357 - Fixes `onStart` not firing when changing URLs - Moves the forced `setVolume` to run on ready instead of every play event
- Fixes cookpete/react-player#357 - Fixes `onStart` not firing when changing URLs - Moves the forced `setVolume` to run on ready instead of every play event
- Fixes cookpete/react-player#357 - Fixes `onStart` not firing when changing URLs - Moves the forced `setVolume` to run on ready instead of every play event
I just updated from
0.25.3
to1.2.1
and encountered this issue :When seeking player position with a Youtube video either programmatically or manually by clicking on the progress bar (video controls must be activated) sound resets to its default value. It also happens when playing / pausing.
How to reproduce
controls
to player's attributesTest A
Preview
The text was updated successfully, but these errors were encountered: