Added the feature to push to Azure blob #100
Conversation
|
The AZURE_BLOB_QUERYSTRING has been added as a environment secret. The AZURE_BLOB_LINK is written directly in the workflow file and is: 'https://carelease.blob.core.windows.net/boards' |
|
Breaking PCB versions have now been added to all projects. So this repo just needs to merge main into it. |
.github/workflows/stm32build.yml
Outdated
| - name: Publish to Azure blob | ||
| run: | | ||
| curl -f -X PUT -H "x-ms-version: 2020-04-08" -H "Content-Type: application/octet-stream" -H "x-ms-blob-type: BlockBlob" \ | ||
| "${{ secrets.AZURE_BLOB_LINK }}/${{ steps.release-on-push.outputs.tag_name }}.zip${{secrets.AZURE_BLOB_QUERYSTRING}}" \ |
There was a problem hiding this comment.
Replace '${{ secrets.AZURE_BLOB_LINK }}' with 'https://carelease.blob.core.windows.net/boards'.
|
Not sure whether it should be included in this PR, but when uploading new releases to the Azure blob we also need to update a file containing the information about current and breaking PCB versions. So I'm guessing we need to add extra logic to the uploading part of the workflow unless I'm misunderstanding the workflow. |
…ile. Added safety checks to ensure all the versions exist in managePCBVersions. Will make initial uploads harder, since versions won't exist, but will prevent errors relating to accidentally referencing versions which don't exist
…y is from the map file. Updated makefile.init to use VERSION_TAG environment variable if available for GIT_VERSION (Software version). Updated workflow to dry run the release manager in order to be able to set the aforementioned environment variable in the build step.
|
@matias-cphatomics When you have time to review, this is ready |
.github/workflows/stm32build.yml
Outdated
| PCB_VERSION_FILE : "STM32/${{ matrix.package }}/pcbversion" | ||
| MODULE_NAME : ${{ matrix.package }} | ||
| - name: Manage PCB Versioning | ||
| run: | |
There was a problem hiding this comment.
Would be nice with a comment explaining this expression.
|
Overall I think it looks very good. A few overall (smaller) comments:
|
…than the uploaded version. Changes quotes after review
Modified YML to point to correct boards repo
To merge this request we need to setup two secrets in the repository
AZURE_BLOB_LINK
AZURE_BLOB_QUERYSTRING