Skip to content

Commit

Permalink
Fix navigation code samples
Browse files Browse the repository at this point in the history
  • Loading branch information
DennisTsar authored and cjbrooks12 committed May 18, 2024
1 parent 5c2084b commit b529733
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 66 deletions.
1 change: 0 additions & 1 deletion .github/workflows/push_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ jobs:
config:
- { target: 'testDebugUnitTest', os: 'ubuntu-latest', java: 17 }
- { target: 'testReleaseUnitTest', os: 'ubuntu-latest', java: 17 }
- { target: 'iosArm64Test', os: 'macos-latest', java: 17 }
- { target: 'iosSimulatorArm64Test', os: 'macos-latest', java: 17 }
- { target: 'iosX64Test', os: 'macos-latest', java: 17 }
- { target: 'jsTest', os: 'ubuntu-latest', java: 17 }
Expand Down
63 changes: 0 additions & 63 deletions .github/workflows/push_features.yml

This file was deleted.

4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.2.1 - 2024-05-17

- Adds `BrowserHashNavigationInterceptor` and `BrowserHistoryNavigationInterceptor` to `wasmJs` target

## 4.2.0 - 2024-05-09

- Increased Kotlin version to 1.9.23
Expand Down
4 changes: 2 additions & 2 deletions docs/src/orchid/resources/wiki/modules/ballast-navigation.md
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ enum class AppScreen(
) : Route {
Home("/app/home"),
PostList("/app/posts?sort={?}"),
PostDetails("/app/posts/{postId}", annotations = listOf(Floating())), // request this route to be displayed in a floating window
PostDetails("/app/posts/{postId}", annotations = setOf(Floating)), // request this route to be displayed in a floating window
;

override val matcher: RouteMatcher = RouteMatcher.create(routeFormat)
Expand All @@ -480,7 +480,7 @@ You can also provide Route Annotations directly to the navigation request:
router.trySend(
RouterContract.Inputs.GoToDestination(
destination = "/app/posts/12345",
extraAnnotations = setOf(Floating()), // normally this destination is displayed fullscreen, but this time only display it in a floating window
extraAnnotations = setOf(Floating), // normally this destination is displayed fullscreen, but this time only display it in a floating window
)
)
```
Expand Down

0 comments on commit b529733

Please sign in to comment.