Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add prettier formatter #849

Merged
merged 4 commits into from
Sep 4, 2024
Merged

config: Add prettier formatter #849

merged 4 commits into from
Sep 4, 2024

Conversation

TDiazT
Copy link
Contributor

@TDiazT TDiazT commented Jul 26, 2024

Adding a base setup to have a formatter for the main extension files.
It is not formatting the goal view nor search ui because they have separate config files, which I think can be handled differently (vite setup).
Fixed some typos.

client/.prettierrc Outdated Show resolved Hide resolved
Comment on lines +15 to +17
},
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question beyond this PR, should these settings be tracked?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't know. My feeling is probably not ?

@rtetley
Copy link
Collaborator

rtetley commented Aug 12, 2024

The CI failures are due to the yarn.nix files not being updated. Could you run the nix-shell -p yarn2nix --run "yarn2nix > ` yarn.nix" command in the client directory ? That should fix it !
Also sorry I pushed a number of things since then 😅
Could you rebase ? I'll then merge !

@TDiazT
Copy link
Contributor Author

TDiazT commented Aug 20, 2024

Having some 🤷 conflicts, if you could check them @rtetley pls.
I am having some trouble displaying the goals as well, so I might have broken something trying to rebase.

@TDiazT
Copy link
Contributor Author

TDiazT commented Aug 20, 2024

Having some 🤷 conflicts, if you could check them @rtetley pls. I am having some trouble displaying the goals as well, so I might have broken something trying to rebase.

There was a little bug in extension.ts. Added a commit renaming the function call (although this one should go on a separate commit probably because it's already in main).

@TDiazT TDiazT changed the title config: Add prettier formatter and fix some typos config: Add prettier formatter Sep 3, 2024
@rtetley
Copy link
Collaborator

rtetley commented Sep 3, 2024

The CI failures are due to the yarn.nix files not being updated. Could you run the nix-shell -p yarn2nix --run "yarn2nix > ` yarn.nix" command in the client directory ? That should fix it ! Also sorry I pushed a number of things since then 😅 Could you rebase ? I'll then merge !

The CI failures are still due to the yarn.nix files. No need to rebase this time though :-)

@rtetley rtetley merged commit c38c713 into coq:main Sep 4, 2024
24 checks passed
@rtetley
Copy link
Collaborator

rtetley commented Sep 4, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants