Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.79.0-nightly warnings #2896

Merged

Conversation

acheroncrypto
Copy link
Collaborator

Problem

rustc 1.79.0-nightly introduces many compilation warnings in the repository:

   Compiling anchor-syn v0.29.0 (/anchor/lang/syn)
warning: the item `Expr` is imported redundantly
 --> /anchor/lang/syn/src/codegen/accounts/constraints.rs:3:5
  |
3 | use syn::Expr;
  |     ^^^^^^^^^
4 |
5 | use crate::*;
  |     -------- the item `Expr` is already imported here
  |
  = note: `#[warn(unused_imports)]` on by default

warning: the item `IdentExt` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/constraints.rs:2:5
  |
1 | use crate::*;
  |     -------- the item `IdentExt` is already imported here
2 | use syn::ext::IdentExt;
  |     ^^^^^^^^^^^^^^^^^^

warning: the item `Parse` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/constraints.rs:3:39
  |
1 | use crate::*;
  |     -------- the item `Parse` is already imported here
2 | use syn::ext::IdentExt;
3 | use syn::parse::{Error as ParseError, Parse, ParseStream, Result as ParseResult};
  |                                       ^^^^^

warning: the item `ParseStream` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/constraints.rs:3:46
  |
1 | use crate::*;
  |     -------- the item `ParseStream` is already imported here
2 | use syn::ext::IdentExt;
3 | use syn::parse::{Error as ParseError, Parse, ParseStream, Result as ParseResult};
  |                                              ^^^^^^^^^^^

warning: the item `Punctuated` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/constraints.rs:4:5
  |
1 | use crate::*;
  |     -------- the item `Punctuated` is already imported here
...
4 | use syn::punctuated::Punctuated;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: the item `Spanned` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/constraints.rs:5:5
  |
1 | use crate::*;
  |     -------- the item `Spanned` is already imported here
...
5 | use syn::spanned::Spanned;
  |     ^^^^^^^^^^^^^^^^^^^^^

warning: the item `Comma` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/constraints.rs:6:5
  |
1 | use crate::*;
  |     -------- the item `Comma` is already imported here
...
6 | use syn::token::Comma;
  |     ^^^^^^^^^^^^^^^^^

warning: the item `Expr` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/constraints.rs:7:22
  |
1 | use crate::*;
  |     -------- the item `Expr` is already imported here
...
7 | use syn::{bracketed, Expr, Ident, Token};
  |                      ^^^^

warning: the item `Ident` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/constraints.rs:7:28
  |
1 | use crate::*;
  |     -------- the item `Ident` is already imported here
...
7 | use syn::{bracketed, Expr, Ident, Token};
  |                            ^^^^^

warning: the item `Punctuated` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/mod.rs:8:5
  |
6 | use crate::*;
  |     -------- the item `Punctuated` is already imported here
7 | use syn::parse::{Error as ParseError, Result as ParseResult};
8 | use syn::punctuated::Punctuated;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: the item `Spanned` is imported redundantly
 --> /anchor/lang/syn/src/parser/accounts/mod.rs:9:5
  |
6 | use crate::*;
  |     -------- the item `Spanned` is already imported here
...
9 | use syn::spanned::Spanned;
  |     ^^^^^^^^^^^^^^^^^^^^^

warning: the item `Comma` is imported redundantly
  --> /anchor/lang/syn/src/parser/accounts/mod.rs:10:5
   |
6  | use crate::*;
   |     -------- the item `Comma` is already imported here
...
10 | use syn::token::Comma;
   |     ^^^^^^^^^^^^^^^^^

warning: the item `Expr` is imported redundantly
  --> /anchor/lang/syn/src/parser/accounts/mod.rs:11:5
   |
6  | use crate::*;
   |     -------- the item `Expr` is already imported here
...
11 | use syn::Expr;
   |     ^^^^^^^^^

warning: the item `TryFrom` is imported redundantly
 --> /anchor/lang/syn/src/hash.rs:6:11
  |
6 | use std::{convert::TryFrom, fmt, mem, str::FromStr};
  |           ^^^^^^^^^^^^^^^^
 --> /rustc/9d5cdf75aa42faaf0b58ba21a510117e8d0051a3/library/std/src/prelude/mod.rs:148:13
  |
  = note: the item `TryFrom` is already defined here

   Compiling aes-gcm-siv v0.10.3
   Compiling merlin v3.0.0
   Compiling sha3 v0.9.1
   Compiling spl-program-error-derive v0.4.0
   Compiling spl-discriminator-syn v0.2.0
   Compiling spl-discriminator-derive v0.2.0
   Compiling anchor-idl v0.29.0 (/anchor/idl)
   Compiling solana-security-txt v1.1.1
   Compiling anchor-derive-space v0.29.0 (/anchor/lang/derive/space)
warning: `anchor-syn` (lib) generated 14 warnings
   Compiling anchor-attribute-account v0.29.0 (/anchor/lang/attribute/account)
warning: the item `TryFrom` is imported redundantly
  --> /anchor/lang/attribute/account/src/id.rs:13:5
   |
13 | use std::convert::TryFrom;
   |     ^^^^^^^^^^^^^^^^^^^^^
  --> /rustc/9d5cdf75aa42faaf0b58ba21a510117e8d0051a3/library/std/src/prelude/mod.rs:148:13
   |
   = note: the item `TryFrom` is already defined here
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `anchor-attribute-account` (lib) generated 1 warning
   Compiling spl-program-error v0.4.0
   Compiling spl-discriminator v0.2.2
   Compiling spl-memo v4.0.1
   Compiling spl-token v4.0.1
   Compiling anchor-attribute-event v0.29.0 (/anchor/lang/attribute/event)
   Compiling solana-zk-token-sdk v1.18.10
warning: `anchor-syn` (lib) generated 14 warnings (14 duplicates)
   Compiling anchor-attribute-access-control v0.29.0 (/anchor/lang/attribute/access-control)
   Compiling anchor-derive-accounts v0.29.0 (/anchor/lang/derive/accounts)
   Compiling anchor-attribute-program v0.29.0 (/anchor/lang/attribute/program)
   Compiling anchor-derive-serde v0.29.0 (/anchor/lang/derive/serde)
   Compiling anchor-attribute-error v0.29.0 (/anchor/lang/attribute/error)
   Compiling anchor-attribute-constant v0.29.0 (/anchor/lang/attribute/constant)
   Compiling anchor-lang v0.29.0 (/anchor/lang)
warning: the item `TryFrom` is imported redundantly
  --> /anchor/lang/src/accounts/program.rs:12:5
   |
12 | use std::convert::TryFrom;
   |     ^^^^^^^^^^^^^^^^^^^^^
  --> /rustc/9d5cdf75aa42faaf0b58ba21a510117e8d0051a3/library/std/src/prelude/mod.rs:148:13
   |
   = note: the item `TryFrom` is already defined here
   |
   = note: `#[warn(unused_imports)]` on by default

warning: the item `AccountInfo` is imported redundantly
 --> /anchor/lang/src/accounts/system_account.rs:5:5
  |
4 | use crate::*;
  |     -------- the item `AccountInfo` is already imported here
5 | use solana_program::account_info::AccountInfo;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: the item `AccountMeta` is imported redundantly
 --> /anchor/lang/src/accounts/system_account.rs:6:5
  |
4 | use crate::*;
  |     -------- the item `AccountMeta` is already imported here
5 | use solana_program::account_info::AccountInfo;
6 | use solana_program::instruction::AccountMeta;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: the item `Pubkey` is imported redundantly
 --> /anchor/lang/src/accounts/system_account.rs:7:5
  |
4 | use crate::*;
  |     -------- the item `Pubkey` is already imported here
...
7 | use solana_program::pubkey::Pubkey;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: the item `BTreeSet` is imported redundantly
 --> /anchor/lang/src/accounts/system_account.rs:9:5
  |
4 | use crate::*;
  |     -------- the item `BTreeSet` is already imported here
...
9 | use std::collections::BTreeSet;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: the item `Pubkey` is imported redundantly
  --> /anchor/lang/src/idl.rs:21:5
   |
20 | use crate::prelude::*;
   |     ----------------- the item `Pubkey` is already imported here
21 | use solana_program::pubkey::Pubkey;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

   Compiling spl-pod v0.2.2
warning: `anchor-lang` (lib) generated 6 warnings
   Compiling spl-type-length-value v0.4.3
   Compiling spl-token-group-interface v0.2.3
   Compiling spl-tlv-account-resolution v0.6.3
   Compiling spl-token-metadata-interface v0.3.3
   Compiling spl-transfer-hook-interface v0.6.3
   Compiling spl-token-2022 v3.0.2
   Compiling spl-associated-token-account v3.0.2
   Compiling anchor-spl v0.29.0 (/anchor/spl)
warning: the item `solana_program` is imported redundantly
 --> /anchor/spl/src/token.rs:6:19
  |
6 | use anchor_lang::{solana_program, Result};
  |                   ^^^^^^^^^^^^^^ the item `solana_program` is already defined by prelude
  |
  = note: `#[warn(unused_imports)]` on by default

warning: the item `solana_program` is imported redundantly
 --> /anchor/spl/src/token_2022.rs:5:19
  |
5 | use anchor_lang::{solana_program, Result};
  |                   ^^^^^^^^^^^^^^ the item `solana_program` is already defined by prelude

Summary of changes

Fix all warnings.

Copy link

vercel bot commented Apr 8, 2024

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto added spl lang next Required for the next release labels Apr 8, 2024
@acheroncrypto acheroncrypto merged commit c7ccbb8 into coral-xyz:master Apr 8, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang next Required for the next release spl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant