feat: add new maps with case sensitive keys #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe Zipitria <[email protected]>
jcchavezs
reviewed
Apr 29, 2024
|
I'll fix tests today. |
Signed-off-by: Felipe Zipitria <[email protected]>
fzipi
force-pushed
the
add-case-sensitive-map
branch
from
d56e6aa
to
5a4b3e6
Compare
Signed-off-by: Felipe Zipitria <[email protected]>
Signed-off-by: Felipe Zipitria <[email protected]>
fzipi
force-pushed
the
add-case-sensitive-map
branch
from
7507ba3
to
4d63f50
Compare
M4tteoP
reviewed
May 1, 2024
There was a problem hiding this comment.
LGTM, what is the plan here? Merge this in Coraza 3.x and then hold #1042 (The breaking change) as part of v4 milestones?
|
I'll be pushing smaller changes until we figure it out. I don't think this will break the api for a major release though. |
|
Can someone from @corazawaf/core-developers approve this, so I can keep pushing stuff on top of this one? |
jcchavezs
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why