Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Announcement] cordova-plugin-iosrtc Version 7.0.x notes #469

Closed
hthetiot opened this issue Feb 25, 2020 · 18 comments
Closed

[Announcement] cordova-plugin-iosrtc Version 7.0.x notes #469

hthetiot opened this issue Feb 25, 2020 · 18 comments
Assignees
Milestone

Comments

@hthetiot
Copy link
Contributor

hthetiot commented Feb 25, 2020

Hello cordova-rtc users,

I will released cordova-plugin-iosrtc 7.0.0 but in the mean time 7.0.0-RC4 is available for testing.

The current work in progress is on the branch https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/7.0.0 and the PR is #475

Changelog Version 7.0.0

  • Update to WebRTC.framework M79
  • Remove WebRTC.framework headers patch

Test 7.0.0-RC3

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/7.0.0 --verbose
cordova platform remove ios --no-save
cordova platform add ios@latest --no-save

Capture

Tested on iOS 12.4.5 on iPhone 6.

Image from iOS (1)

@hthetiot hthetiot added this to the 7.0.0 milestone Feb 25, 2020
@hthetiot hthetiot self-assigned this Feb 25, 2020
@hthetiot
Copy link
Contributor Author

@hthetiot
Copy link
Contributor Author

hthetiot commented May 24, 2020

7.0.0-RC3 available for testing based on 6.0.12 changes.
See: #425 (comment)

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC3 --verbose

@numerized
Copy link

Hi here, testing RC2 ok so far, thanks a lot!
RC3 gives me this:

Set IPHONEOS_DEPLOYMENT_TARGET to "11.0".
iOS Product Name has not changed (still "Bandcast")
Updating icons at platforms/ios/Bandcast/Images.xcassets/AppIcon.appiconset/
Updating launch storyboard images at platforms/ios/Bandcast/Images.xcassets/LaunchStoryboard.imageset/
Updating Storyboard image set contents.json
This app does not have additional resource files defined
Prepared iOS project successfully
Executing script found in plugin cordova-plugin-add-swift-support for hook "after_prepare": plugins/cordova-plugin-add-swift-support/src/add-swift-support.js
Executing script found in plugin cordova-plugin-iosrtc for hook "after_prepare": plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js
Cannot read property '1' of null
TypeError: Cannot read property '1' of null
    at getProjectName (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:35:56)
    at module.exports (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:131:17)
    at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32)
    at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16)
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
[ERROR] An error occurred while running subprocess cordova.
        
        cordova platform add ios@latest --verbose exited with exit code 1.
        
        Re-running this command with the --verbose flag may provide more information.
  ionic:utils-process onBeforeExit handler: 'process.exit' received +0ms
  ionic:utils-process onBeforeExit handler: running 1 functions +0ms
  ionic:utils-process processExit: exiting (exit code: 1) +37ms```

@hthetiot
Copy link
Contributor Author

Thank you @numerized we will fix or update minimal iOS target requirements.

Your help is appreciated.

@numerized
Copy link

sure let me know if need more tests.

@hthetiot
Copy link
Contributor Author

hthetiot commented Jul 7, 2020

Thank you @numerized, you can test 7.0.0-RC3 based on 6.0.12 changes if you want.

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC3 --verbose
cordova platform remove ios --no-save
cordova platform add ios@latest --no-save

@hthetiot
Copy link
Contributor Author

hthetiot commented Jul 7, 2020

Hopefuly your issue with TypeError: Cannot read property '1' of null via /extra/hooks/iosrtc-swift-support.js has been addressed.

@hthetiot hthetiot modified the milestones: 7.0.x, 7.0.0 Jul 17, 2020
@hthetiot
Copy link
Contributor Author

@numerized M84 is available here #545

@numerized
Copy link

Hi @hthetiot, I still experience the bug, even if I follow strictly #545 instructions.
Now by the way, I have this error with the default cordova plugin add cordova-plugin-iosrtc --variable MANUAL_INIT_AUDIO_DEVICE=TRUE

Thanks for your work, if you have any question ping me.

Cannot read property '1' of null
TypeError: Cannot read property '1' of null
    at getProjectName (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:36:53)
    at module.exports (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:137:17)
    at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32)
    at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16)
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
[ERROR] An error occurred while running subprocess cordova.```

@numerized
Copy link

this version works
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC2 --variable MANUAL_INIT_AUDIO_DEVICE=TRUE --verbose

@hthetiot
Copy link
Contributor Author

this version works
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC2 --variable MANUAL_INIT_AUDIO_DEVICE=TRUE --verbose

@numerized Can you test https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC3 please and let me know here. Thx.

@hthetiot hthetiot changed the title [Announcement] cordova-plugin-iosrtc Version 7.0.x notes [Announcement] cordova-plugin-iosrtc Version 7.0.0-RC3 notes Jul 25, 2020
@numerized
Copy link

numerized commented Jul 26, 2020

Same issue with RC3:

Executing script found in plugin cordova-plugin-add-swift-support for hook "after_prepare": plugins/cordova-plugin-add-swift-support/src/add-swift-support.js
Executing script found in plugin cordova-plugin-iosrtc for hook "after_prepare": plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js
Cannot read property '1' of null
TypeError: Cannot read property '1' of null
    at getProjectName (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:35:56)
    at module.exports (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:131:17)
    at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32)
    at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16)
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20```

@hthetiot
Copy link
Contributor Author

Same issue with RC3:

Executing script found in plugin cordova-plugin-add-swift-support for hook "after_prepare": plugins/cordova-plugin-add-swift-support/src/add-swift-support.js
Executing script found in plugin cordova-plugin-iosrtc for hook "after_prepare": plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js
Cannot read property '1' of null
TypeError: Cannot read property '1' of null
    at getProjectName (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:35:56)
    at module.exports (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:131:17)
    at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32)
    at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16)
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20```

Arf I will fill an issue @numerized

@hthetiot
Copy link
Contributor Author

@numerized Hum can you check you setup (NVM) or check Cordova version. Travis does not reproduce, can you provide node version ?

@hthetiot hthetiot changed the title [Announcement] cordova-plugin-iosrtc Version 7.0.0-RC3 notes [Announcement] cordova-plugin-iosrtc Version 7.0.0-RC4 notes Aug 4, 2020
@numerized
Copy link

numerized commented Aug 9, 2020

$ node -v 
v10.21.0
$ cordova --version
10.0.0

I was on cordova9 last weeks, I'll try again with the 10.0.0 Thanks

@hthetiot
Copy link
Contributor Author

@numerized

I never tried with Cordova 10, version 9 work perfectly. I think the error is due some data in your config.xml such as the app name. Try running the sample app here: https://github.com/cordova-rtc/cordova-plugin-iosrtc-sample

Please fill a separate issue for your error if you do reproduce with sample or can provide steps to reproduce.

@hthetiot
Copy link
Contributor Author

Updated to M79

@hthetiot hthetiot changed the title [Announcement] cordova-plugin-iosrtc Version 7.0.0-RC4 notes [Announcement] cordova-plugin-iosrtc Version 7.0.0 notes Oct 18, 2020
@hthetiot hthetiot changed the title [Announcement] cordova-plugin-iosrtc Version 7.0.0 notes [Announcement] cordova-plugin-iosrtc Version 7.0.x notes Oct 18, 2020
@hthetiot
Copy link
Contributor Author

hthetiot commented Mar 1, 2021

7.0.0 will not be released and instead 8.0.0 will be released directly.
See https://github.com/cordova-rtc/cordova-plugin-iosrtc/issues?q=milestone%3A8.0.0+is%3Aclosed

@hthetiot hthetiot closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants