Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update WebRTC.framework to M87 #545

Merged
merged 32 commits into from
Mar 1, 2021
Merged

update WebRTC.framework to M87 #545

merged 32 commits into from
Mar 1, 2021

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Jul 17, 2020 •
edited
Loading

WebRTC M84 Release Notes https://groups.google.com/forum/#!msg/discuss-webrtc/MRAV4jgHYV0/5019yB-HAwAJ

Testing

To test task/8.0.0 branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

@hthetiot hthetiot mentioned this pull request Jul 17, 2020
Closed
@hthetiot hthetiot self-assigned this Jul 17, 2020
This was referenced Jul 17, 2020
Merged
Closed
@hthetiot hthetiot added this to the 8.0.0 milestone Jul 21, 2020
@hthetiot hthetiot mentioned this pull request Sep 11, 2020
Closed
3 tasks
@akilude
Copy link
Contributor

akilude commented Sep 13, 2020

I tried this branch out, getting the issue of all incoming streams having the same video feed when using janus, this does not occur when using master or the task/7.0.0 branch.

@hthetiot
Copy link
Contributor Author

hthetiot commented Sep 14, 2020 •
edited
Loading

I tried this branch out, getting the issue of all incoming streams having the same video feed when using janus, this does not occur when using master or the task/7.0.0 branch.

@akilude thx, i merged master on 8.0.0 like i did previously on 7.0.0:
Find attached the diff, there is nothing that let me beleive that this should append at least after the merge.
7vs8.txt

See https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/task/8.0.0/src/PluginMediaStream.swift#L23

cc @numerized

@hthetiot hthetiot mentioned this pull request Oct 7, 2020
Closed
1 task
@hthetiot
Copy link
Contributor Author

merged master from 6.0.14

@hthetiot hthetiot changed the title update WebRTC.framework to M84 update WebRTC.framework to M87 Oct 17, 2020
@hthetiot hthetiot changed the base branch from master to task/7.0.0 October 23, 2020 21:52
@hthetiot hthetiot changed the base branch from task/7.0.0 to master October 23, 2020 21:53
@hthetiot
Copy link
Contributor Author

I will rebase master after 6.0.17, Typescript is 6.1.0 and 8.0.0.will land Transceiver and Typescript while 7.0.0 is short lived for M79 will be followed by M86 or M87 if released by Chromium then.

@hthetiot hthetiot mentioned this pull request Jan 4, 2021
Closed
3 tasks
hthetiot and others added 7 commits January 4, 2021 16:40
@hthetiot
merge master
cb2d012
@axel-calmid
Basic transceiver scaffolding.
b7dbce0 
* Create native class for transceivers.
* Extend js class for transceivers.
* Add RTCPeerConnection.addTransceiver.
* Set up basic callback for sending native state to js.
@axel-calmid
Add support for stop and direction.
2db54be 
* Invoke the native transceiver stop function.
* Allow setting direction from JS.
* State event for updating the JS state.
@axel-calmid
Add string to direction utility function.
4a463d5 
* Added PluginRTCRtpTransceiver#stringToDirection()
* Fixed typo rendonly -> sendonly.
@axel-calmid
Create native and js transceiver on pc event.
6115210
@axel-calmid
Add support for addTransceiver(of:)
350aaf1
@axel-calmid
Associate transceivers with sender/receiver/track.
9a78663
@hthetiot hthetiot changed the base branch from master to task/7.0.0 January 20, 2021 18:04
hthetiot and others added 7 commits January 21, 2021 12:43
@hthetiot
merge master
1070603
@axel-calmid
Transient ID's for native transceivers.
dc9802c 
* Instead of having permanent ID's for the JS -> Transceiver
association, just have transient ones until the next transceiver state
update. Until better solution can be found.
* Reduce complexity of transceiver constructor.
@axel-calmid
Fix issue with undefined init object.
4c286a8
@axel-calmid
Update sender parameters state and parse sendEncodings.
e6a837d 
* Update sender parameters along with transceivers.
* Parse and pass along sendEncodings when doing addTransceiver.
@hthetiot
merge 7.0.0
2a278e3
@hthetiot
fix bad merge RTCRtpSender.h
7c63115
@hthetiot
Merge pull request #625 from agelito/task/589/implement-addtransceiver
0297b39 
WIP: Task/589/implement addtransceiver
This was referenced Mar 1, 2021
Merged
Closed
@hthetiot hthetiot changed the base branch from task/7.0.0 to master March 1, 2021 16:36
@hthetiot hthetiot merged commit 5442062 into master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hthetiot hthetiot

Labels
enhancement libwebrtc waiting for testing
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hthetiot @akilude @axel-calmid