add setDefaultAudioOutput to source #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerry2013 thx for PR. |
|
Good catch. |
|
did that and the only changes are version number and copyright year. |
|
Thx @jerry2013 I will take care of version and copyright. It's not part of PR ;) |
hthetiot
reviewed
Apr 15, 2023
| @@ -1,9 +1,9 @@ | |||
| /* | |||
| * cordova-plugin-iosrtc v8.0.2 | |||
| * cordova-plugin-iosrtc v8.0.3 | |||
There was a problem hiding this comment.
This come from package when generated.
It's not the role of a PR to increment version.
There was a problem hiding this comment.
Indeed I was very confused why the CHANGELOG.md says 8.0.3 (commit from 10 months ago) but the cordova-plugin-iosrtc.js on the master is 8.0.2.
|
Released into [email protected] , can you test to confirm your fix please, thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#767 only contains changes to the compiled artifact and not the source - this is to add the same code so that
npm run buildwon't lose the change.