Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/select update #1405

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Feat/select update #1405

merged 4 commits into from
Oct 11, 2024

Conversation

NikitaRodyukov
Copy link
Contributor

@NikitaRodyukov NikitaRodyukov commented Oct 9, 2024 •
edited
Loading

  1. Добавил пропс onSelectAllClick в хук useSelectWithApply
  2. Исправил прокидку пропса headerProps в хуке useSelectWithApply
  3. Добавил параметр name в обработчик onChange для кнопок "Применить" и "Сбросить"
  4. Добавлен dataTestId для чекбокса "Выбрать все"
  5. Исправлена ситуация с пустым списком опций и отображаемым футером

@NikitaRodyukov
feat(select): select update
ad26e0b 
added onSelectAllClick prop to UseSelectWithApply hook, added parametr name to onChange handler
@NikitaRodyukov
feat(select): added dataTestId for checkbox in header, fixed dataTest…
88ca465 
…Id value in docs
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 83939ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@alfalab/core-components-select Minor
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Oct 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11288708497

Details

  • 2 of 11 (18.18%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 82.587%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/select/src/presets/useSelectWithApply/hook.tsx 1 4 25.0%
packages/select/src/presets/useSelectWithApply/options-list-with-apply/header/Component.tsx 1 7 14.29%
Totals Coverage Status
Change from base Build 11253394442: -0.04%
Covered Lines: 10340
Relevant Lines: 11450
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@NikitaRodyukov NikitaRodyukov marked this pull request as ready for review October 10, 2024 05:39
hextion
hextion approved these changes Oct 10, 2024
View reviewed changes
.changeset/fuzzy-windows-camp.md Show resolved Hide resolved
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben merged commit 290acf4 into master Oct 11, 2024
7 of 8 checks passed
@SiebenSieben SiebenSieben deleted the feat/select-update branch October 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hextion hextion hextion approved these changes

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@fulcanellee fulcanellee Awaiting requested review from fulcanellee fulcanellee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NikitaRodyukov @coveralls @core-ds-bot @SiebenSieben @reme3d2y @hextion