Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): added mobile and responsive versions component #687

Merged
merged 30 commits into from
Aug 7, 2023

Conversation

Valeri8888
Copy link
Contributor

добавлены мобильная и адаптивная версии компонента

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2023

🦋 Changeset detected

Latest commit: 35c7e65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 47 packages
Name Type
@alfalab/core-components-calendar Minor
@alfalab/core-components-input-autocomplete Minor
@alfalab/core-components-pass-code Minor
@alfalab/core-components-pattern-lock Minor
@alfalab/core-components-select Minor
@alfalab/core-components-tooltip Minor
@alfalab/core-components-button Major
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-attach Patch
@alfalab/core-components-confirmation-v1 Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-custom-button Patch
@alfalab/core-components-icon-button Patch
@alfalab/core-components-input Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-plate Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-toast-plate Patch
@alfalab/core-components-amount-input Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-alert Patch
@alfalab/core-components-notification Patch
@alfalab/core-components-toast Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-phone-input Patch
@alfalab/core-components-notification-manager Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented May 26, 2023

Pull Request Test Coverage Report for Build 5759172038

  • 60 of 60 (100.0%) changed or added relevant lines in 29 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 80.474%

Files with Coverage Reduction New Missed Lines %
packages/calendar/src/components/calendar-mobile/Component.tsx 1 37.91%
Totals Coverage Status
Change from base Build 5736680835: 0.9%
Covered Lines: 8232
Relevant Lines: 9258

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben requested a review from Oladii May 26, 2023 09:05
@core-ds-bot
Copy link
Collaborator

core-ds-bot commented May 29, 2023

Bundle size report

Entry point Size (minified)
tooltip/responsive.js 0 (-93.20 KB)
tooltip/mobile.js 67.49 (+67.49 KB🔺)
tabs/desktop.js 12.39 (-201.25 KB)
tabs/index.js 14.6 (-200.04 KB)
tabs/mobile.js 12.55 (-201.22 KB)
tabs/responsive.js 0 (-214.67 KB)
tabs/collapsible.js 159.47 (+159.47 KB🔺)
tabs/shared.js 15.81 (+15.81 KB🔺)
table/index.js 141.82 (-69.05 KB)
system-message/responsive.js 0 (-6.78 KB)
side-panel/responsive.js 0 (-61.12 KB)
side-panel/shared.js 39.74 (+39.74 KB🔺)
select/index.js 192.65 (-11.67 KB)
select/mobile.js 163.1 (-37.19 KB)
select/responsive.js 0 (-200.69 KB)
select/desktop.js 126.09 (+126.09 KB🔺)
select/shared.js 152.66 (+152.66 KB🔺)
select-with-tags/index.js 152.94 (-53.95 KB)
picker-button/desktop.js 151.58 (-52.38 KB)
picker-button/responsive.js 0 (-204.88 KB)
picker-button/shared.js 3.01 (+3.01 KB🔺)
modal/responsive.js 0 (-57.74 KB)
modal/shared.js 39.74 (+39.74 KB🔺)
intl-phone-input/index.js 663.17 (-53.67 KB)
input-autocomplete/desktop.js 152.76 (-52.39 KB)
input-autocomplete/mobile.js 170.83 (-37.24 KB)
input-autocomplete/responsive.js 0 (-207.93 KB)
gallery/index.js 191.51 (-15.15 KB)
custom-picker-button/desktop.js 153.05 (-53.27 KB)
custom-picker-button/responsive.js 0 (-208.11 KB)
confirmation/desktop.js 26.9 (+2.42 KB🔺)
confirmation/mobile.js 27.01 (+2.41 KB🔺)
confirmation/responsive.js 0 (-25.44 KB)
confirmation/shared.js 25.41 (+25.41 KB🔺)
calendar-with-skeleton/index.js 63.45 (+2.02 KB🔺)
button/desktop.js 6.75 (+6.75 KB🔺)
button/mobile.js 6.75 (+6.75 KB🔺)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 requested a review from v-gevak June 6, 2023 09:47
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben
Copy link
Contributor

Предлагаю добавить скриншот-тестов

@Valeri8888
Copy link
Contributor Author

Предлагаю добавить скриншот-тестов

добавила

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben
Copy link
Contributor

Заметил опечатку, которая не относится к этому реквесту:
image

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888
Copy link
Contributor Author

Заметил опечатку, которая не относится к этому реквесту: image

фикс

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit 2e453cf into master Aug 7, 2023
6 of 8 checks passed
@v-gevak v-gevak deleted the feat/button-mobile-component branch August 7, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants