Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tag): added mobile and responsive versions component #700

Merged
merged 21 commits into from
Aug 7, 2023
Merged

feat(tag): added mobile and responsive versions component #700

merged 21 commits into from
Aug 7, 2023

Conversation

Valeri8888
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 2b6842c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@alfalab/core-components-tag Major
@alfalab/core-components-filter-tag Major
@alfalab/core-components-pagination Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-table Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@coveralls
Copy link

coveralls commented Jun 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5747835964

  • 49 of 49 (100.0%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 79.663%
Totals Coverage Status
Change from base Build 5736680835: 0.06%
Covered Lines: 8193
Relevant Lines: 9298
💛 - Coveralls

@Valeri8888 Valeri8888 marked this pull request as ready for review June 2, 2023 07:29
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Jun 7, 2023 •
edited
Loading

Bundle size report

Entry point Size (minified)
tooltip/responsive.js 0 (-93.20 KB)
tooltip/mobile.js 67.49 (+67.49 KB🔺)
tag/index.js 6.29 (+2.11 KB🔺)
tag/desktop.js 4.6 (+4.60 KB🔺)
tag/mobile.js 4.6 (+4.60 KB🔺)
tabs/desktop.js 12.87 (-200.77 KB)
tabs/index.js 15.36 (-199.28 KB)
tabs/mobile.js 13.02 (-200.75 KB)
tabs/responsive.js 0 (-214.67 KB)
tabs/collapsible.js 159.5 (+159.50 KB🔺)
tabs/shared.js 15.81 (+15.81 KB🔺)
table/index.js 142.23 (-68.64 KB)
system-message/responsive.js 0 (-6.78 KB)
side-panel/responsive.js 0 (-61.12 KB)
side-panel/shared.js 39.74 (+39.74 KB🔺)
select/index.js 192.65 (-11.67 KB)
select/mobile.js 163.1 (-37.19 KB)
select/responsive.js 0 (-200.69 KB)
select/desktop.js 126.09 (+126.09 KB🔺)
select/shared.js 152.66 (+152.66 KB🔺)
select-with-tags/index.js 153.35 (-53.54 KB)
picker-button/desktop.js 151.58 (-52.38 KB)
picker-button/responsive.js 0 (-204.88 KB)
picker-button/shared.js 3.01 (+3.01 KB🔺)
modal/responsive.js 0 (-57.74 KB)
modal/shared.js 39.74 (+39.74 KB🔺)
intl-phone-input/index.js 663.17 (-53.67 KB)
input-autocomplete/desktop.js 152.76 (-52.39 KB)
input-autocomplete/mobile.js 170.83 (-37.24 KB)
input-autocomplete/responsive.js 0 (-207.93 KB)
gallery/index.js 191.51 (-15.15 KB)
filter-tag/desktop.js 7.42 (+7.42 KB🔺)
filter-tag/mobile.js 7.41 (+7.41 KB🔺)
custom-picker-button/desktop.js 153.05 (-53.27 KB)
custom-picker-button/responsive.js 0 (-208.11 KB)
confirmation/desktop.js 26.9 (+2.42 KB🔺)
confirmation/mobile.js 27.01 (+2.41 KB🔺)
confirmation/responsive.js 0 (-25.44 KB)
confirmation/shared.js 25.41 (+25.41 KB🔺)
calendar-with-skeleton/index.js 63.45 (+2.02 KB🔺)
button/desktop.js 6.75 (+6.75 KB🔺)
button/mobile.js 6.75 (+6.75 KB🔺)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 requested a review from v-gevak June 19, 2023 08:36
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 requested a review from Oladii June 19, 2023 11:04
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

v-gevak
v-gevak reviewed Jun 22, 2023
View reviewed changes
jest.screenshots.config.js Outdated Show resolved Hide resolved
@Valeri8888 Valeri8888 requested a review from v-gevak June 23, 2023 06:57
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

SiebenSieben
SiebenSieben reviewed Aug 7, 2023
View reviewed changes
packages/tabs/src/__image_snapshots__/click-tabs-tabs-desktop-view-1-size-1-2-snap.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На многих скринах теги с заливкой стали с обводкой. Почему так происходит?

Copy link
Contributor

@SiebenSieben SiebenSieben Aug 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можем добавить кодмод?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И выглядит как будто не всё в ченджлоге написали

@v-gevak v-gevak merged commit 06b4a0b into master Aug 7, 2023
7 of 8 checks passed
@v-gevak v-gevak deleted the feat/tag-mobile-component branch August 7, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben left review comments

@reme3d2y reme3d2y reme3d2y approved these changes

@v-gevak v-gevak v-gevak approved these changes

@Oladii Oladii Oladii approved these changes

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Valeri8888 @core-ds-bot @coveralls @SiebenSieben @reme3d2y @v-gevak @Oladii