Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(steps): make checkIsStepCustom's return value nullable #738

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

annette-st
Copy link
Contributor

Добавлена возможность возвращать null для функции checkIsStepCustom, так как это необходимо для применения кастомной иконки к конкретному шагу, иначе иконка будет применяться ко всем шагам.

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2023

🦋 Changeset detected

Latest commit: dbfe76c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-steps Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Copy link
Contributor

@EGNKupava EGNKupava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо еще в тип компонента Step добавить null, customStepIndicator?: StepIndicatorProps | null

@coveralls
Copy link

coveralls commented Jul 5, 2023

Pull Request Test Coverage Report for Build 5572359022

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 79.683%

Files with Coverage Reduction New Missed Lines %
packages/input-autocomplete/src/Component.modal.mobile.tsx 20 9.09%
Totals Coverage Status
Change from base Build 5416416283: -0.02%
Covered Lines: 8103
Relevant Lines: 9204

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@@ -0,0 +1,5 @@
---
"@alfalab/core-components-steps": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это минорка

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit a464a29 into master Jul 18, 2023
8 checks passed
@v-gevak v-gevak deleted the fix/steps_checkIsStepCustom_type branch July 18, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants