-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(steps): make checkIsStepCustom's return value nullable #738
Conversation
🦋 Changeset detectedLatest commit: dbfe76c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Собрана новая демка. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Надо еще в тип компонента Step добавить null, customStepIndicator?: StepIndicatorProps | null
Pull Request Test Coverage Report for Build 5572359022
💛 - Coveralls |
Собрана новая демка. |
.changeset/clean-carrots-judge.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
"@alfalab/core-components-steps": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это минорка
Собрана новая демка. |
Добавлена возможность возвращать null для функции checkIsStepCustom, так как это необходимо для применения кастомной иконки к конкретному шагу, иначе иконка будет применяться ко всем шагам.