Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plate): added mobile and responsive versions component #743

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

Valeri8888
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

🦋 Changeset detected

Latest commit: ff35d7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@alfalab/core-components-plate Major
@alfalab/core-components-alert Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Jul 13, 2023

Bundle size report

Entry point Size (minified)
plate/desktop.js 11.35 (+11.35 KB🔺)
plate/mobile.js 11.34 (+11.34 KB🔺)

@coveralls
Copy link

coveralls commented Jul 13, 2023

Pull Request Test Coverage Report for Build 5747649317

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 79.623%

Totals Coverage Status
Change from base Build 5736680835: 0.02%
Covered Lines: 8150
Relevant Lines: 9256

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben requested a review from Oladii July 14, 2023 05:31
Copy link
Contributor

@reme3d2y reme3d2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiebenSieben @Oladii
А тут нельзя было обойтись просто респонсив версией? Докинуть медиа в css и пусть себе стили меняются по брейкпоинту. Кажется сейчас слишком много телодвижений, чтобы 2 класса стилей накинуть

packages/plate/src/Component.desktop.tsx Outdated Show resolved Hide resolved
packages/plate/src/Component.mobile.tsx Outdated Show resolved Hide resolved
@Valeri8888 Valeri8888 requested a review from reme3d2y July 18, 2023 07:05
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

1 similar comment
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit be9aadf into master Aug 7, 2023
1 of 8 checks passed
@v-gevak v-gevak deleted the feat/plate_mobile branch August 7, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants