feat(intl-phone-input): add handlers #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e83c2e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 5677907222
💛 - Coveralls |
|
Собрана новая демка. |
|
Собрана новая демка. |
v-gevak
reviewed
Jul 27, 2023
| @@ -459,6 +461,7 @@ export const IntlPhoneInput = forwardRef<HTMLInputElement, IntlPhoneInputProps>( | |||
| const resultNumber = preparedNumber.substring(0, maxPhoneLength + 1); | |||
|
|
|||
| if (resultNumber) { | |||
| inputProps?.onPaste?.(event); | |||
There was a problem hiding this comment.
Почему коллбэк вызывается при условии? Он на каждый вызов handlePaste вызываться должен, думаю
There was a problem hiding this comment.
просто текст из буфера вставляется после проверок выше.
Думаешь правильно вызывать хендлер вставки если текст не вставился в поле по итогу?
There was a problem hiding this comment.
Думаю, что да. ИМХО он должен вызываться по событию paste
|
Собрана новая демка. |
v-gevak
approved these changes
Jul 27, 2023
Valeri8888
approved these changes
Aug 1, 2023
EGNKupava
approved these changes
Aug 1, 2023
SiebenSieben
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
При прокидывании хендлеров onClear и onPaste они перетирают логику компонента.
Ожидаемое поведение
Нужно чтобы хендлеры для inputProps вызывались не нарушаю внутреннюю логику хендлеров компонента IntlPhoneInput