Enable cmake/FindNodejs.cmake to find more libnode versions
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would previously hardcode a list of Node module versions which we would "support" and find automatically; we however did and do not really vet these versions. This meant that we were preptually unable to find newer Node library versions until we patch the CMake module. With this patch we automatically populate a list of current and future Node module versions we recognize. Compilation might still fail down the line, but this blanket discovery should simplify working with newer Node versions nevertheless.
awelzel
reviewed
Nov 15, 2024
| # Since we do not explicitly vet particularly Node releases we automatically | ||
| # enable this code to find Node libraries with module versions in a certain | ||
| # range. | ||
| foreach(NODE_MODULE_VERSION 83 150) |
There was a problem hiding this comment.
This is nice, thanks! I think the nightly build as some baseline failures, but I'll pick this up once I've sorted that.
There was a problem hiding this comment.
Thanks! I am assigning the PR to you for tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would previously hardcode a list of Node module versions which we would "support" and find automatically; we however did and do not really vet these versions. This meant that we were preptually unable to find newer Node library versions until we patch the CMake module.
With this patch we automatically populate a list of current and future Node module versions we recognize. Compilation might still fail down the line, but this blanket discovery should simplify working with newer Node versions nevertheless.