Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: build on minimum and current toolchains #91

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Jun 22, 2018

This checks that master and further PRs won't break on current
toolchains, nor on older ones used by downstream distributions
(pinning to 1.26 for historical ContainerLinux compatibility).

This checks that master and further PRs won't break on current
toolchains, nor on older ones used by downstream distributions
(pinning to 1.26 for historical ContainerLinux compatibility).
@lucab lucab changed the title travis: build on both minimum and current toolchains travis: build on minimum and current toolchains Jun 22, 2018
@lucab
Copy link
Contributor Author

lucab commented Jun 22, 2018

I enabled a travis weekly job for this repo so that it'll catch if master breaks with newer toolchains.

Copy link
Contributor

@sdemos sdemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sdemos
Copy link
Contributor

sdemos commented Jun 22, 2018

Digging into this more, it looks like the nightly build failed. I'm okay merging it anyway (since we allow failures on that one) but I thought the error was strange and I couldn't figure out where it was coming from.

@lucab
Copy link
Contributor Author

lucab commented Jun 22, 2018

@sdemos it failed because of rust-lang/rust#51699. Which is (one of) the reason why nightly is allowed to fail :)

@sdemos
Copy link
Contributor

sdemos commented Jun 22, 2018

ha I love getting hitting things and discovering that it was literally introduced yesterday. that happened to me with the new panic_implementation macro replacing lang(panic) too. I was surprised by it and discovered it was merged earlier that day when I hit it.

anyway, thanks!

@sdemos sdemos merged commit d70be3e into coreos:master Jun 22, 2018
@lucab lucab deleted the ups/travis branch June 22, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants