-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fcos|r4e|flatcar spec stabilization #442
Conversation
2c61d9f
to
a7bc548
Compare
In the middle of re-organizing the commits to be a little bit more palatable. Try not to put too much weight on the commit structure atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left notes on some substantive issues pending the restructuring of commits.
Just a simple rename of folder to drop 'exp'.
Just a simple copy paste
Simple copy and paste of latest existing stable r4e version.
a7bc548
to
64bbb81
Compare
Well there are a large number of commits, however I tried to keep it very tidy. LMK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good. Thanks for restructuring the commits; it made for a much cleaner review.
0512ba2
to
38eda9a
Compare
vendor/github.com/coreos/ignition/v2/config/v3_5_experimental/types/clevis.go
Outdated
Show resolved
Hide resolved
efec681
to
cb29881
Compare
Additonally fix comment in v1_0/ to indicate version butane flatcar version 1.0.
Simple copy and paste of latest existing stable flatcar version.
Simple rename
Simple copy and paste from fcos-v1_5.md
Update versions to be approprate to each file, additonally update the nav_order.
1e8984b
to
b1387ef
Compare
b1387ef
to
e8a1f99
Compare
Simple rename
simple copy and paste from latest stable flatcar version
Update versions to be appropriate for each file, additonally update nav_order and ignition version
Simple rename
Simple copy and paste of latest stable version
Update versions to be appropriate for each file, additonally update nav_order and ignition version
For all experimental specs go ahead and point to latest exp version of ignition. Update tests and functions.
e8a1f99
to
7091f48
Compare
#434