Skip to content

Commit

Permalink
build-sys: Require explicit make schema-update to regenerate
Browse files Browse the repository at this point in the history
Alternative to #1306

My recent change to use make for this seems to have introduced
a race condition mainly in Prow; perhaps something is not
preserving timestamps.

Files stored in git should not be touched
via a default make, as that is both subject to timestamp
problems and also creates friction.

So this change now requires an explicit manual generation; and
we also consistently add the generated doc file to git too.
  • Loading branch information
cgwalters authored and openshift-merge-robot committed Apr 2, 2020
1 parent 1b53134 commit 84553ee
Show file tree
Hide file tree
Showing 3 changed files with 640 additions and 3 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ maipo/
*.pyo
*.shellchecked
.coverage
mantle/cosa/schema_doc.go
4 changes: 2 additions & 2 deletions mantle/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ DESTDIR ?=
ARCH:=$(shell uname -m)

.PHONY: build test vendor clean
build: cosa/schema_doc.go
build:
./build cmd/*

cosa/schema_doc.go: ../src/schema/v1.json Makefile
schema-update:
./build schema

.PHONY: install
Expand Down
Loading

0 comments on commit 84553ee

Please sign in to comment.