-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building Hyperv images #3350
Conversation
Hi @baude. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Diff LGTM. "Add HyperV support" is a bit ambiguous as a commit message title, and the commit body has a similar issue. Could you update the commit message to clarify that the commit is adding support for building a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trivial LGTM
The commit text is better, but still claims to implement more than we're actually doing at this phase. Proposal:
(We don't use signoffs generally.) |
Add a buildextend-hyperv command that creates a `hyperv` image in VHDX format. Supports coreos/fedora-coreos-tracker#1411.
Ok, amended and fixor'd up in gh too. |
Followup in #3546. |
Add a buildextend-hyperv command that creates a
hyperv
image in VHDX format.Supports coreos/fedora-coreos-tracker#1411