Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building Hyperv images #3350

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Add support for building Hyperv images #3350

merged 1 commit into from
Feb 16, 2023

Conversation

baude
Copy link
Contributor

@baude baude commented Feb 13, 2023

Add a buildextend-hyperv command that creates a hyperv image in VHDX format.

Supports coreos/fedora-coreos-tracker#1411

@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2023

Hi @baude. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bgilbert
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

pkg/builds/cosa_v1.go Outdated Show resolved Hide resolved
@bgilbert
Copy link
Contributor

Diff LGTM.

"Add HyperV support" is a bit ambiguous as a commit message title, and the commit body has a similar issue. Could you update the commit message to clarify that the commit is adding support for building a hyperv image?

dustymabe
dustymabe previously approved these changes Feb 14, 2023
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial LGTM

@baude baude changed the title Add hyperV support Add support for building Hyperv images Feb 14, 2023
@bgilbert
Copy link
Contributor

The commit text is better, but still claims to implement more than we're actually doing at this phase. Proposal:

Add support for building HyperV images

Add a buildextend-hyperv command that creates a `hyperv` image in VHDX
format.

Supports https://github.com/coreos/fedora-coreos-tracker/issues/1411.

(We don't use signoffs generally.)

Add a buildextend-hyperv command that creates a `hyperv` image in VHDX
format.

Supports coreos/fedora-coreos-tracker#1411.
@baude
Copy link
Contributor Author

baude commented Feb 15, 2023

Ok, amended and fixor'd up in gh too.

@bgilbert bgilbert enabled auto-merge (rebase) February 15, 2023 20:57
@bgilbert bgilbert merged commit 8b224ab into coreos:main Feb 16, 2023
@bgilbert
Copy link
Contributor

Followup in #3546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants