Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mantle: fix offline detection in testiso tests #3553

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

dustymabe
Copy link
Member

The offline detection in our testiso tests is not working properly meaning we are never running offline tests today. Let's fix that here by parsing it properly.

Fixes f98481f.

The offline detection in our testiso tests is not working properly
meaning we are never running offline tests today. Let's fix that
here by parsing it properly.

Fixes f98481f.
@dustymabe dustymabe enabled auto-merge (rebase) August 9, 2023 19:35
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travier
Copy link
Member

travier commented Aug 10, 2023

/retest

Copy link
Member

@ravanelli ravanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

@dustymabe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos ac8a24d link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dustymabe
Copy link
Member Author

Turns out RHCOS CI doesn't run testiso for COSA PRs so I'm just going to merge this.

@dustymabe dustymabe merged commit 829271a into coreos:main Aug 10, 2023
2 checks passed
@dustymabe dustymabe deleted the dusty-testiso-offline branch August 10, 2023 20:32
@dustymabe
Copy link
Member Author

/cherry-pick rhcos-4.14
/cherry-pick rhcos-4.13
/cherry-pick rhcos-4.12
/cherry-pick rhcos-4.11
/cherry-pick rhcos-4.10
/cherry-pick rhcos-4.9

@openshift-cherrypick-robot

@dustymabe: new pull request created: #3557

In response to this:

/cherry-pick rhcos-4.14
/cherry-pick rhcos-4.13
/cherry-pick rhcos-4.12
/cherry-pick rhcos-4.11
/cherry-pick rhcos-4.10
/cherry-pick rhcos-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe
Copy link
Member Author

/cherry-pick rhcos-4.13

@dustymabe
Copy link
Member Author

/cherry-pick rhcos-4.12

@openshift-cherrypick-robot

@dustymabe: new pull request created: #3558

In response to this:

/cherry-pick rhcos-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@dustymabe: new pull request created: #3559

In response to this:

/cherry-pick rhcos-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe
Copy link
Member Author

/cherry-pick rhcos-4.11

@dustymabe
Copy link
Member Author

/cherry-pick rhcos-4.10

@dustymabe
Copy link
Member Author

/cherry-pick rhcos-4.9

@openshift-cherrypick-robot

@dustymabe: new pull request created: #3560

In response to this:

/cherry-pick rhcos-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@dustymabe: new pull request created: #3561

In response to this:

/cherry-pick rhcos-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@dustymabe: new pull request created: #3562

In response to this:

/cherry-pick rhcos-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants