-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mantle: fix offline detection in testiso tests #3553
Conversation
The offline detection in our testiso tests is not working properly meaning we are never running offline tests today. Let's fix that here by parsing it properly. Fixes f98481f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dustymabe: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Turns out RHCOS CI doesn't run testiso for COSA PRs so I'm just going to merge this. |
/cherry-pick rhcos-4.14 |
@dustymabe: new pull request created: #3557 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick rhcos-4.13 |
/cherry-pick rhcos-4.12 |
@dustymabe: new pull request created: #3558 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dustymabe: new pull request created: #3559 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick rhcos-4.11 |
/cherry-pick rhcos-4.10 |
/cherry-pick rhcos-4.9 |
@dustymabe: new pull request created: #3560 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dustymabe: new pull request created: #3561 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dustymabe: new pull request created: #3562 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The offline detection in our testiso tests is not working properly meaning we are never running offline tests today. Let's fix that here by parsing it properly.
Fixes f98481f.