-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kola/tests: add openshift
tag to OCP tests
#3741
Conversation
Skipping CI for Draft Pull Request. |
Before doing this, we need to tweak things so that those tests keep running in the !layered streams. (A "layered stream" here refers to a stream built using the approach in openshift/os#1445). Edit: I've changed the approach here to be more incremental: we still add an |
This is part of openshift/os#1445. Those tests are all actually testing OCP components. In the new model, they should be run against an OCP layered image instead. Add a tag on them so that we'll be able to run them separately.
openshift
required tag to OCP testsopenshift
tag to OCP tests
/retest |
This is now ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One question, out of curiosity: Will it become a required tag in the future?
Thanks for reviewing! Yes, probably. Once we've fully switched over to the new stream, then it becomes easier in the pipelines to use required tags so that the kola run on the base compose doesn't have to do |
This is part of openshift/os#1445.
Those tests are all actually testing OCP components. In the new model,
they should be run against an OCP layered image instead. Add a tag on
them so that we'll be able to run them separately.