buildextend-live: Add support OSBUILD #3861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ravanelli
commented
Aug 19, 2024
ravanelli
commented
- Add support for OSBUILD via COSA_USE_LIVEISO env var for now
We run osbuild inside of supermin, so for building the live ISO we'll need all the tools it needs in there. This includes `genisoimage` and `syslinux-nonlinux`. We don't currently name `squashfs-tools` as a toplevel dependency. It's currently pulled in by libguestfs, but we need it in supermin too, so explicitly list it there.
This adds a new osbuild pipeline for building the live ISO using the new `org.osbuild.coreos.live-iso` mega stage. Still missing is changing `cmd-buildextend-live` to call osbuild instead. I think we'll need to ratchet this in using e.g. an env var like we did for the other osbuild artifacts. E.g. `COSA_OSBUILD_LIVE` would control whether to use the old logic or the new one. And then turn it on in rawhide, etc... The new `cmd-buildextend-live` would also take care of extracting the live artifacts from the live ISO to insert into `meta.json`.
ravanelli
force-pushed
the
pr/cosa_live
branch
from
4bbcf0a
to
75f616f
Compare
ravanelli
force-pushed
the
pr/cosa_live
branch
2 times, most recently
from
954c139
to
543fdf6
Compare
dustymabe
reviewed
Oct 17, 2024
jlebon
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Two of the commits have a leading space in their titles.
The last commit is missing a blank line between the title and the body, which messes up git log --oneline.
Agree we should wait until we finalize the stage before adding the pipeline here. Though if you'd like, we can at least get the prep commits in for now in a separate PR.
…e naming - Rename `ignition_img_size` to `IGNITION_IMG_SIZE` and `miniso_data_file_size` to `MINISO_DATA_FILE_SIZE` for consistent naming convention; - Move these definitions to the top level for better visibility and maintainability Signed-off-by: Renata Ravanelli <[email protected]>
…creation - Moved variable declarations and directories creation into generate_iso() to enhance clarity and maintainability. Signed-off-by: Renata Ravanelli <[email protected]>
- Moved variable declarations to top to enhance clarity. Signed-off-by: Renata Ravanelli <[email protected]>
ravanelli
force-pushed
the
pr/cosa_live
branch
from
543fdf6
to
7e84e2c
Compare
- Add support for OSBUILD via COSA_OSBUILD_LIVEISO env var for now. Once we finish the OSBUILD integration we can disable it via var. Signed-off-by: Renata Ravanelli <[email protected]>
ravanelli
force-pushed
the
pr/cosa_live
branch
from
7e84e2c
to
ba12dc1
Compare
|
@ravanelli: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.