Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

kube-aws: add ECR policies to IAMRoleWorker #384

Merged
merged 1 commit into from
May 26, 2016

Conversation

spacepluk
Copy link
Contributor

No description provided.

@spacepluk
Copy link
Contributor Author

Fixes #381

@colhom
Copy link
Contributor

colhom commented Apr 14, 2016

@spacepluk my concern here is that deploying a kube-aws cluster does not imply a need for the instances to have IAM access to ECR images on that AWS account. Maybe this should be configurable, and default to no IAM access?

@valichek
Copy link

valichek commented May 3, 2016

@spacepluk the list of policies is not full, here is suggested policies http://kubernetes.io/docs/user-guide/images/#using-aws-ec2-container-registry, @colhom kubernetes supports ECR by default. So why not to configure it from the box?

@spacepluk
Copy link
Contributor Author

Sorry, I completely missed these comments.

@colhom that's a good point but I'd say it makes sense to support it by default.

@valichek thanks, I'll update the patch.

@yuvipanda
Copy link

It would be awesome to have this merged :D

@colhom
Copy link
Contributor

colhom commented May 26, 2016

Here is a link to the docs for the ECR-K8s integration @valichek was referring to.

Given that this integration exists, I've been convinced. Thanks everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants