This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
Fix vpc validation for multiple subnets #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| c.AvailabilityZone = "dummy-az-0" | ||
| } | ||
|
|
||
| out, err := yaml.Marshal(&c) |
There was a problem hiding this comment.
This is why 5341bf3 exists. We're using the config.Cluster to automate pre-processing of test yaml data.
|
Code lgtm Are you keeping track / setting target versions for deprecation of "legacy" features? |
colhom
force-pushed
the
fix-vpc-validation
branch
from
f6da415
to
43e7ac3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a kind-of-off-topic commit which introduces omitempty tags for the Cluster yaml fields. This is subtly desirable behavior I would think, in that defining an empty value in
cluster.yamlshould probably imply the preset default rather than empty.Fixes bug 2 in #500
\cc @aaronlevy @michaeldiscala