This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
etcd: expose more configs for the etcd pods. #2124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyliuliming
force-pushed
the
andliu/more_configs_exposed
branch
from
6bc1bfe
to
1f94d7e
Compare
|
this will also address the issue: |
|
Hi @hexfusion , could you please help do a review? thank very much. |
|
Will this fix be released, and if so, when can we expect it? |
nvtkaszpir
reviewed
Mar 16, 2020
| FailureThreshold int `json:"failureThreshold,omitempty"` | ||
| } | ||
|
|
||
| type EtcdConfig struct { |
There was a problem hiding this comment.
most of this parameters can be controlled directly via env vars, and etcd-opreator already supports in as env vars in .spec.pod.etcdEnv.
I would leave in here only k8s specific ones - liveness and readiness probes, but also would rather reconsider it and put that in pod spec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
people may have requirements that have control on the etcd behaviour in more details.