-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: use Go 1.9+ #6174
Milestone
Comments
move to 3.2. we will release 3.2 with go 1.8. |
This hack https://github.com/coreos/etcd/blob/master/pkg/transport/transport.go#L66-L71 doesn't work with 1.8 anymore :( |
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Mar 20, 2017
For etcd-io#6174. Signed-off-by: Gyu-Ho Lee <[email protected]>
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Mar 20, 2017
For etcd-io#6174. Signed-off-by: Gyu-Ho Lee <[email protected]>
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Apr 13, 2017
ref. etcd-io#6174. Signed-off-by: Gyu-Ho Lee <[email protected]>
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Apr 13, 2017
ref. etcd-io#6174. Signed-off-by: Gyu-Ho Lee <[email protected]>
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Apr 13, 2017
ref. etcd-io#6174. Signed-off-by: Gyu-Ho Lee <[email protected]>
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Apr 13, 2017
ref. etcd-io#6174. Signed-off-by: Gyu-Ho Lee <[email protected]>
This was referenced Apr 13, 2017
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Apr 20, 2017
Go just updated its import path golang/time@c06e80d For etcd-io#6174. Signed-off-by: Gyu-Ho Lee <[email protected]>
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Apr 21, 2017
For etcd-io#6174. Signed-off-by: Gyu-Ho Lee <[email protected]>
Moving to 3.3. Hopefully, Go 1.9 addresses golang/protobuf#336. |
Closing and opening a new issue on contexts in generated code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
golang.org/x/net/context
withcontext
within etcd (done via *: deprecate 'golang.org/x/net/context' #8511)context
packagesgolang.org/x/net/context
withcontext
in upstream dependenciesstaticcheck
(done via pkg/transport, rafthttp: CancelableTransport #7602)io.Seek*
*: use 'os.SEEK_*' #6296time.Until
(done via *: clean up for Go 1.8+ #7737)tls.Config
copy method https://golang.org/pkg/crypto/tls/#Config.Clone to replaceShallowCopyTLSConfig
at https://github.com/coreos/etcd/blob/master/pkg/transport/listener.go (done via *: clean up for Go 1.8+ #7737)mutex
profile handler toembed/serve.go
https://golang.org/pkg/runtime/pprof/#Profile (done via pkg/debugutil: add 'mutex' profiler (Go 1.8+) #7765)*url.URL.Hostname()
,*url.URL.Port()
https://golang.org/doc/go1.8#net_url (done via embed: use '*url.URL.Hostname(),Port()' for Go 1.8 #7766)CloseNotify
inServeHTTP
net/http: closeNotify does not work well when read timeout is set golang/go#9524 (comment) (not needed for etcd use case?)http.Server.Shutdown
https://golang.org/doc/go1.8#http_shutdown (done via embed: gracefully close peer handler #7879)net.DialContext
,http.Transport.DialContext
inpkg/transport
(TODO: done via pkg/transport, rafthttp: CancelableTransport #7602)http.Request.WithContext
forhttputil.RequestCanceler
The text was updated successfully, but these errors were encountered: