x/time/rate: use context package from Go 1.7+ #16745
Labels
Milestone
Comments
|
They're mostly compatible, so we'll probably keep external libraries using golang.org/x/net/context for awhile so we don't break Go 1.6 users. That is, you can use a stdlib context.Context and pass it to a function taking a golang.org/x/net/context. There are some cases where it's not as nice, but it mostly works out. Did you hit specific problems? If we had type aliases (#16339) this would've been less gross. |
|
@bradfitz We don't have any problem. Just trying to plan in advance, along with grpc. As you suggest, we can just keep external context for awhile. We will revisit this if we hit any problem. Thanks! |
|
CL https://golang.org/cl/41194 mentions this issue. |
gopherbot
pushed a commit
to golang/time
that referenced
this issue
Apr 24, 2017
https://golang.org/cl/41194 updatd the x/time/rate package to use the standard library's context package for golang/go#16745 but App Engine is stuck 14 months in the past and can only run Go 1.6, which lacks context. This CL restores Go 1.6 support. The Go build system stopped testing packages against Go 1.6 once Go 1.8 came out, so just disable the tests for Go 1.6 rather than jumping through hoops to make them work. Change-Id: I271dcd492dd0ca53961340d63b26facb5dbdf025 Reviewed-on: https://go-review.googlesource.com/41624 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Chris Broadfoot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hope this is the right place to ask this question.
Could anybody provide some timeline on switching
golang.org/x/net/contexttocontext?When would this happen?
Reference
Thanks!
The text was updated successfully, but these errors were encountered: