Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt rules to use new gRPC metrics #8879

Merged
merged 2 commits into from
Nov 15, 2017
Merged

Conversation

brancz
Copy link
Contributor

@brancz brancz commented Nov 15, 2017

This adapts the provided example alerting rules for Prometheus to use the new gRPC metrics coming from grpc-go-prometheus and fixes the incorrect link introduced in #8848 (comment).

@xiang90 @gyuho

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d01f3da). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8879   +/-   ##
=========================================
  Coverage          ?   76.03%           
=========================================
  Files             ?      359           
  Lines             ?    29719           
  Branches          ?        0           
=========================================
  Hits              ?    22598           
  Misses            ?     5538           
  Partials          ?     1583

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01f3da...092b270. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks! /cc @xiang90

@xiang90
Copy link
Contributor

xiang90 commented Nov 15, 2017

lgtm

@xiang90 xiang90 merged commit 4a8c788 into etcd-io:master Nov 15, 2017
@brancz brancz deleted the adapt-rules branch November 15, 2017 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants