Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext-tests/ext Fix var-mount/scsi-id failure on rawhide #2943

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

jbtrystram
Copy link
Contributor

Update the scsci-id test to set a WWN for the disk, and use reliable udev symlinks to adjust for a change in sg3_utils [1]

Note that the wwn value set is converted to base 16 by QEMU, so the symlink in the ignition config must reflects it.

This requires coreos/coreos-assembler#3772 See coreos/fedora-coreos-tracker#1670

[1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html

@jbtrystram jbtrystram requested a review from c4rt0 April 5, 2024 13:20
@jbtrystram
Copy link
Contributor Author

jbtrystram commented Apr 5, 2024

@dustymabe you were so quick to review I could not post my follow-up comment :)

Let's hold this for now : coreos/coreos-assembler#3772 (comment)

EDIT: now it's fixed :)

Update the scsci-id test to set a WWN for the disk, and use reliable
udev symlinks to adjust for a change in sg3_utils [1]

Note that the `wwn` value set is converted to base 16 by QEMU,
so the symlink in the ignition config must reflects it.

This requires coreos/coreos-assembler#3772
See coreos/fedora-coreos-tracker#1670

[1] https://listman.redhat.com/archives/dm-devel/2023-March/053645.html
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this LGTM, I have no idea how the hardcoded wwn value works in additionalDisks: ["5G:channel=scsi,wwn=123456789"] - is it a templating thing?

@dustymabe
Copy link
Member

Even though this LGTM, I have no idea how the hardcoded wwn value works in additionalDisks: ["5G:channel=scsi,wwn=123456789"] - is it a templating thing?

That value is one we add so that we can ID the related block device inside the VM. My understanding is that in this case the driver takes the decimal value and converts it to hexadecimal underneath, so the symlink that shows up in the VM is hexadecimal.

@jbtrystram
Copy link
Contributor Author

@c4rt0 looks at coreos/coreos-assembler#3772 for how the wwn option is passed to qemu.
As dusty explains, the value nd up being converted to hex, i don't know why.
I only found very few documentation around that wwn option.

@jbtrystram jbtrystram merged commit 9251127 into coreos:testing-devel Apr 12, 2024
3 checks passed
@jbtrystram jbtrystram deleted the fix/mount.scsi-id branch April 12, 2024 07:59
jbtrystram added a commit to jbtrystram/fedora-coreos-config that referenced this pull request Apr 12, 2024
An update in rawhide broke /dev/disk-by symlinks that the scsi-id
relied on. [1] fixed the test but i forgot to re-enable it

[1] coreos#2943
c4rt0 pushed a commit that referenced this pull request Apr 12, 2024
An update in rawhide broke /dev/disk-by symlinks that the scsi-id
relied on. [1] fixed the test but i forgot to re-enable it

[1] #2943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants