Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add a test that can be run manually for net testing #316

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

dustymabe
Copy link
Member

This is how I've been doing network testing for the NM in
the initrd PR (#310).
One day I'd like to convert this into some more sophisticated
test that can be run in our CI but AFAIU right now that's not
possibly because our CI is limited to qemu unprivileged networking.

For now let's put this $somewhere so that we can pull it out
at least when we suspect problems.

@dustymabe
Copy link
Member Author

I went though and talked to @jlebon about where would be the best place to put something like this. We came up with tests/manual in this repo for now. I don't know if there are problems with doing that or not, but this is an attempt at that.

@dustymabe dustymabe force-pushed the dusty-net-test branch 2 times, most recently from 8423768 to 3cdfc62 Compare March 24, 2020 22:26
This is how I've been doing network testing for the NM in
the initrd PR (coreos#310).
One day I'd like to convert this into some more sophisticated
test that can be run in our CI but AFAIU right now that's not
possibly because our CI is limited to qemu unprivileged networking.

For now let's put this $somewhere so that we can pull it out
at least when we suspect problems.
@cgwalters
Copy link
Member

OK yeah, this looks like a net win. See some discussions in coreos/fedora-coreos-tracker#340 for libvirt.

@cgwalters cgwalters merged commit c95f3af into coreos:testing-devel Mar 30, 2020
@lucab
Copy link
Contributor

lucab commented Mar 31, 2020

Isn't this something that belongs to coreos-assembler / mantle? Even if not part of automated CI, it would helpful not to start sprawling scripts around.

@dustymabe dustymabe deleted the dusty-net-test branch April 1, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants